Example: Pin Floating UI lib #4796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example PR!
The
@floating-uidependencies have to be manually pinned inpackage-lock.jsonafter each package update before the releases.Why
There are conflicts with
@floating-ui/react-domand above, which still has to be resolved. Pinning only the top-level library isn't enough and requires a manual "pin" of sub-packages.The package-lock.json file from WP 6.2 can be used as a base - https://github.com/WordPress/wordpress-develop/blob/6.2/package-lock.json#L1652-L1672.
More details: WordPress/gutenberg#48402.
Reference from WP 6.2 updates: #4155 (comment)
Iframed editor bug with popovers
CleanShot.2023-07-05.at.15.10.16.mp4