Pin floating-ui/react-dom version
#48402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 24, 2023
|
Flaky tests detected in 4031dba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4262046166
|
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
force-pushed
the
pin/floating-ui-react-dom
branch
from
1d1e8e4 to
4031dba
Compare
gziolo
approved these changes
Feb 24, 2023
ciampo
approved these changes
Feb 24, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 15b60c2 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
|
@ciampo, @mirka, did you get a chance to track down what was causing this breaking change with the latest versions of This hotfix requires a manual Screenshot
|
|
@Mamaduka Marco is away for the next two months, but looking into the trail, it's likely that this attempted upstream fix is messing with our custom workaround (#46845). The iframe issue in floating-ui is definitely still on our todo list, but I'm afraid we don't have an ETA yet 🙁 But thanks for letting us know about this hassle — it will bump up the priority 🙏 |
|
Thank you, @mirka 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48059
Fixes: #48398
Similar to: #48237
Why?
Core resolves different version
1.3.0and it seems something has changed that causes these problems.Ideally we should update the version in GB and resolve the issues, but beta 4 is in a few days. So I think this
hotfixfor core it's an acceptable temporary solution.Testing Instructions
We'll need to do a packages update for 6.2 to verify it resolves the issues.