Pin valtio version
#48237
Merged
Pin valtio version
#48237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
ellatrix
approved these changes
Feb 20, 2023
|
Flaky tests detected in 94dca6f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4221613110
|
ntsekouras
added a commit
that referenced
this pull request
Feb 20, 2023
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #47923
Let's pin valtio's version to see if it fixes the WP beta issues with the Popovers. It seems that the resolved version in GB for valtio is
1.7.0but in core build is resolving to1.10.2.As @gziolo mentioned:
Let's try option one for beta3.