Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Supports: Backport update from Gutenberg #5252

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Sep 20, 2023

Trac ticket: #59443

See WordPress/gutenberg#54075

Refactors block supports to use a single Tag Processor instance and to only send a single class at a time to add_class().

See WordPress/gutenberg#54075

Refactors block supports to use a single Tag Processor instance and to only
send a single class at a time to `add_class()`.
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, changes LGTM. Any reason this is still in draft? I assume we want it committed before Beta 1 tomorrow.

Are you able to open a Trac ticket for this? GH PRs are only for code review.

@dmsnell
Copy link
Member Author

dmsnell commented Sep 25, 2023

Any reason this is still in draft?

not sure; I probably didn't have time at the end of the day to create the Trac ticket and so left it as a draft. created that now.

@dmsnell dmsnell marked this pull request as ready for review September 25, 2023 19:22
@tellthemachines
Copy link
Contributor

Committed in r56698.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants