Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null coalescing operator from layout. #5302

Conversation

tellthemachines
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/59443

Follow-up to #5252: replaces uses of null coalescing operator in that PR due to it not being officially supported in WP yet.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit-pick feedback.

src/wp-includes/block-supports/layout.php Outdated Show resolved Hide resolved
src/wp-includes/block-supports/layout.php Outdated Show resolved Hide resolved
tellthemachines and others added 2 commits September 26, 2023 16:19
Add spaces inside brackets

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Add spaces inside brackets

Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@tellthemachines
Copy link
Contributor Author

Committed in r56700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants