-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background block supports: add support for top-level styles in theme.json #6482
Background block supports: add support for top-level styles in theme.json #6482
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
6305245
to
02b410a
Compare
b1f04ae
to
84b6c19
Compare
84b6c19
to
cf2da5e
Compare
Syncing changes for Global styles: background UI controls #59454 Global styles: add background image to top-level theme.json styles #59354 Background block supports: move block support defaults to gutenberg_render_background_support and revert gutenberg_get_background_support_styles #59889
… a source is later required
cf2da5e
to
a0a496d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took this branch for a spin without the Gutenberg plugin activated. I tested setting a background image via Global Styles on TT4 and creating a new theme with Create Block Theme, setting a background via Global Styles, and then saving those changes to theme.json
. All worked as expected.
LGTM but maybe fix up that ??
since I think we're not supposed to use them. (I can't actually remember.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 – do you need me to commit?
Thank you!! Yes please! I have pleb rights. |
Committed in r58222. |
Syncing Gutenberg PRs:
Trac ticket: https://core.trac.wordpress.org/ticket/61123
How to test
This PR enables top-level background images. You can:
2024-05-28.12.11.42.mp4