Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test Blueprints v1 #756

Open
13 tasks
adamziel opened this issue Nov 19, 2023 · 1 comment
Open
13 tasks

Unit test Blueprints v1 #756

adamziel opened this issue Nov 19, 2023 · 1 comment
Assignees
@reimic
Labels
Tests [Type] Developer Experience

Comments

@adamziel
Copy link
Collaborator

adamziel commented Nov 19, 2023 •
edited
Loading

Let's unit test the following Blueprint steps that don't have any unit tests yet:

  • defineSiteUrl
  • exportWxr
  • exportWxz
  • importFile
  • importWordPressFiles
  • mkdir
  • request
  • runWpInstallationWizard
  • setPhpIniEntry
  • rmdir
  • unzip
  • writeFile
  • zipWpContent

In addition, some steps (like installTheme) are tested through runBlueprintSteps and not with a direct call – let's explore simplifying that and using direct calls instead.

cc @reimic
@adamziel adamziel changed the title Enhance Blueprints unit tests Unit test Blueprints Nov 19, 2023
@reimic
Copy link
Contributor

reimic commented Nov 19, 2023

On it!

@adamziel adamziel mentioned this issue Feb 29, 2024
Open
20 tasks
@adamziel adamziel mentioned this issue Jan 31, 2024
Open
This was referenced Feb 8, 2024
Closed
Merged
@adamziel adamziel added this to the Zero Crashes milestone Feb 29, 2024
adamziel added a commit that referenced this issue Mar 4, 2024
@reimic @adamziel
Blueprints: add unit tests to the mkdir step (#1029)
daeef68 
Adds tests to the mkdir step.

Tests directory creation minding idempotence and recursivity. 

Part of the #756 effort.

---------

Co-authored-by: Adam Zielinski <adam@adamziel.com>
@adamziel adamziel changed the title Unit test Blueprints Unit test Blueprints v1 Mar 13, 2024
@adamziel adamziel moved this to Future work in Playground Board Jun 30, 2024
@adamziel adamziel removed this from the Zero Crashes milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reimic reimic

Labels
Tests [Type] Developer Experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamziel @reimic