Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints: add unit tests to the mkdir step #1029

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Conversation

reimic
Copy link
Contributor

@reimic reimic commented Feb 11, 2024

What does this PR do?

Adds tests to the mkdir step.

Tests directory creation minding idempotence and recursivity.

Part of the #756 effort.

@adamziel
Copy link
Collaborator

adamziel commented Feb 11, 2024

I am slightly surprised this step allows for creation of directories with periods in their name.

Periods are valid characters in directory names, see this StackOverflow reply about forbidden characters.

Also, if you could confirm my understanding: this step never fails - it will either do what it is told to do, or do nothing (if the requested directory already exists).

I can't remember off the top of my head, but if it doesn't throw an exception when the directory already exists, then you're right.

@adamziel adamziel added [Package][@wp-playground] Blueprints [Type] Reliability Playground uptime, reliability, not crashing labels Feb 11, 2024
reimic and others added 2 commits March 4, 2024 13:06
Co-authored-by: Adam Zielinski <adam@adamziel.com>
Co-authored-by: Adam Zielinski <adam@adamziel.com>
@adamziel
Copy link
Collaborator

adamziel commented Mar 4, 2024

@reimic looks good, let's clean up the PR description and I'm happy to merge.

@adamziel adamziel merged commit daeef68 into WordPress:trunk Mar 4, 2024
5 checks passed
@adamziel
Copy link
Collaborator

adamziel commented Mar 4, 2024

Thank you @reimic !

@reimic reimic deleted the mkdir branch March 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Blueprints [Type] Reliability Playground uptime, reliability, not crashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants