-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints: add unit tests to the mkdir step #1029
Conversation
Periods are valid characters in directory names, see this StackOverflow reply about forbidden characters.
I can't remember off the top of my head, but if it doesn't throw an exception when the directory already exists, then you're right. |
Co-authored-by: Adam Zielinski <adam@adamziel.com>
Co-authored-by: Adam Zielinski <adam@adamziel.com>
@reimic looks good, let's clean up the PR description and I'm happy to merge. |
Thank you @reimic ! |
What does this PR do?
Adds tests to the mkdir step.
Tests directory creation minding idempotence and recursivity.
Part of the #756 effort.