Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symbol names in the web version of PHP for easier debugging #1156

Closed
wants to merge 1 commit into from

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Mar 29, 2024

What is this PR doing?

Related to #1152

Preserves the symbol names in web PHP builds to enable debugging based on the reports collected by the error reporting modal.

Unfortunately, it increases the light bundle size by 250-400kb and the kitchen sink bundle size by ~700kb.

Open questions

  • Would it be possible to produce a separate DWARF file instead and use it to decipher the minified stack traces? Could it work as a web app? Or could the error collector endpoint apply that transform? It would be an extra step and could require additional tooling, so we might need to merge this one first and tackle that as a follow-up issue.

Testing instructions

Just confirm the tests are green.

@adamziel adamziel added this to the Zero Crashes milestone May 16, 2024
@adamziel adamziel force-pushed the trunk branch 2 times, most recently from 680cd19 to 2e376d2 Compare October 4, 2024 09:24
@adamziel adamziel removed this from the Zero Crashes milestone Nov 28, 2024
@adamziel
Copy link
Collaborator Author

The JSPI PHP build isn't crashing nearly as much as the Asyncify one so there isn't a good reason to merge this anymore. I'm going to close this PR.

@adamziel adamziel closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant