Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve symbol names in the web version of PHP for easier debugging #1156

Closed
wants to merge 1 commit into from
Closed

Preserve symbol names in the web version of PHP for easier debugging #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/php-wasm/compile/php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,11 +354,9 @@ RUN set -euxo pipefail; \
echo -n ' --source-map-base http://localhost:5400/@fs/Users/cloudnik/www/Automattic/core/plugins/playground/packages/php-wasm/web/public/${PHP_VERSION_ESCAPED}/' >> /root/.emcc-php-wasm-flags; \
fi; \
else \
# Preserve symbol names in node.js build – the bundle size doesn't matter as much
# as on the web, and this makes debugging **much** easier.
if [ "$EMSCRIPTEN_ENVIRONMENT" = "node" ]; then \
echo -n ' -g2 ' >> /root/.emcc-php-wasm-flags; \
fi; \
# Preserve the symbol names. They add ~200kb to the build and
# make debugging much easier.
echo -n ' -g2 ' >> /root/.emcc-php-wasm-flags; \
fi;

# PHP < 8.0 errors out with "null function or function signature mismatch"
Expand Down
Loading
Loading