WordPress Build: Use Playground CLI to produce minified WordPress build (without the SQLite integration plugin) #1426

adamziel · 2024-05-18T16:14:09Z

Uses Playground CLI to produce the minified WordPress builds:

$ bun \
    packages/playground/cli/src/cli.ts run-blueprint \
    --wp=https://wordpress.org/6.5.zip \
    --mount-before-install=./wordpress-site:/wordpress

Those new builds ships without the SQLite database integration plugin but with the SQLite database file containing all the data and tables created by a vanilla WordPress installation.

Advantages:

Less code to maintain – Playground CLI replaces a custom bash script relying on wget, unzip, sed, wp-cli etc.
More testing for our internal tools – we're dogfooding Playground CLI and the boot protocol in the critical code path.

Testing instructions

Confirm the CI checks passed – this is about as good of a testing as we can get.
Run npm run dev and confirm the local Playground loads without any issues.

Run bun packages/playground/cli/src/cli.ts server --login and confirm it loads an installed WordPress.

Related: #1398

…ld (without the SQLite integration plugin) Uses Playground CLI to produce a minified WordPress build, replacing the custom bash-based WordPress installation flow that relied on wget, unzip, sed, wp-cli etc. This is to dogfood Playground CLI and put the boot protocol to a practical use. With this PR, CLI Playground produces a minified WordPress version that is later used to boot the web Playground. Depends on #1423 #1423 #1425 ## Testing instructions Rebuild the latest WordPress with ```shell rm -rf packages/playground/wordpress-builds/public/wp-6.5 npx nx bundle-wordpress:major-and-beta playground-wordpress-builds ``` Then run npm run dev and confirm the local Playground loads without any issues. Related: #1398

Replaces a series of custom steps meant to unzip and configure WordPress with passinf the build zip as a preferredVersion. To test, go to the WordPress PR previewer locally and try previewing one of the recent PRs. Confirm the installed WordPress versions is indeed not the latest stable. Do not merge until these PRs are merged: * #1423 * #1424 * #1425 * #1426 * #1427

…if there's no custom db.php inside wp-content (#1424) This PR always preloads the SQLite plugin in remote.html, even if the provided WordPress already ships one. The preloaded plugin will only be used if no `wp-content/db.php` drop-in plugin is found in the filesystem. This change sets the stage for: * #1426, which ships a minified WordPress build without the SQLite plugin baked-in. * #1425, which runs the WordPress installation wizard if the site isn't installed yet Related to [Boot Protocol](#1398) ## Problem solved We want the official WordPress release `.zip` to just work in Playground. Currently it doesn't because remote.html expects a pre-processed build with the SQLite plugin already baked-in. This PR, in conjunction with #1425 and #1426, remove that requirement. ## Testing Instructions Confirm the CI checks pass.

## What is this PR doing? Runs the WordPress installation process in remote.html when the loaded WordPress instance isn't installed yet. This is to enable the official WordPress release `.zip` to just work in Playground. Currently it doesn't because remote.html expects a pre-installed WordPress build with a pre-populated SQLite database already baked-in. This PR, in conjunction with #1425 and #1426, remove that requirement. Related to [Boot Protocol](#1398) ## Testing Instructions Confirm the CI checks pass.

Removes the special MODE_EVAL_CODE in which the PHP code to evaluate is fed to the interpreter as a string. Inline code snippets are now written to a special file called `/internal/eval.php` and executed as regular PHP files. ## Rationale PHP does not correctly load the php.ini file when the code is passed as a string. This change also reduces the number of forks in the most cricitcal code path in the project – PHP execution. ## Remaining work * Rebuild all the PHP bundles, not just 8.0 ## Testing instructions Confirm the CI checks pass

This PR removes the duplicate PHP ZIP functions declarations. It only leaves a single `unzip()` function declaration and a single `zipDir()` function declaration. Furthermore, they're no longer imported across modules but live where they're used. ## Testing instructions Confirm the CI checks pass

…without-sqlite-plugin

brandonpayton · 2024-05-21T19:06:30Z

@adamziel It looks like you are doing merges instead of rebasing within this PR to avoid rewriting history within the PR. Is that right? It's something I've been thinking about because force-pushing after rebasing makes it difficult to follow the progress of the PR over time because changes are hidden and conversations lost or made less visible.

adamziel · 2024-05-22T03:06:57Z

@brandonpayton I'm merging mostly because rebasing requires replaying this branch through all the recent trunk commits and often solving the same conflicts multiple times. There are trade-offs either way 🤷 e.g. the merge commits add noise and can disguise extra changes done during the conflict resolution.

brandonpayton · 2024-05-22T03:13:42Z

Thanks for offering your thoughts, @adamziel ☺️

…out-sqlite-plugin

bgrgicak

This PR breaks logging. You can test it using this blueprint.

Error: Could not write to "/wordpress/wp-content/mu-plugins/error.php": There is no such file or directory OR the parent directory does not exist.

adamziel · 2024-05-28T09:00:02Z

@bgrgicak with this change in, you have to create /wordpress/wp-content/mu-plugins before calling writeFile – that's consistent with the official WordPress release which does not ship the mu-plugins directory. A Blueprint, to work on both, would need to create that file. If we continue creating it for the user, it will mess with locally mounted WordPress installations.

adamziel · 2024-05-28T20:57:55Z

Let's ensure writeFile to mu-plugins would create the underlying directory under the hood to keep the existing Blueprints working. That workaround won't make it to the Blueprints v2 PHP library and we'll likely continue using this TypeScript code for maximum compat.

… to writeFile to it

adamziel added [Type] Enhancement New feature or request [Package][@wp-playground] Remote [Package][@wp-playground] WordPress Builds labels May 18, 2024

This was referenced May 18, 2024

WordPress PR Previewer: Simplify the Blueprint #1429

Merged

Remote.html: Preload the SQLite database plugin, but only execute it if there's no custom db.php inside wp-content #1424

Merged

adamziel mentioned this pull request May 20, 2024

Remote.html: Install WordPress if it isn't installed yet #1425

Merged

adamziel added 16 commits May 20, 2024 11:01

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

eafa1a9

Bugfixes to split into separate branches

b2b3b5b

Rebuild php

8a328e2

Merge branch 'simplify-zip-functions-setup' into produce-minified-wp-…

16eb131

…without-sqlite-plugin

Merge branch 'wasm_remove_run_php_function' into produce-minified-wp-…

fd24eac

…without-sqlite-plugin

Blueprints: Re-activate single-file plugins when enabling a multisite

8ef3805

Boot Protocol prototype for the browser and CLI

1396bdf

Start migrating CLI to the boot function

ce3e9e5

Revert the refactor of wordpress/src/index.ts

cb20078

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

e028c3a

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

34703ce

Don't say "for the changelog" in refresh WP jobs

c97f30b

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

3f52b85

Explore wp-cli fix

cb13a14

Define the SQLITE_MAIN_FILE constant to prevent activate_plugin() calls

2f58686

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

ced37c8

adamziel requested a review from a team as a code owner May 23, 2024 02:07

adamziel added 6 commits May 22, 2024 22:07

Merge branch 'playground-boot-protocol' into produce-minified-wp-with…

2278701

…out-sqlite-plugin

save progress

ad9f8bb

Save progress

6231572

Save progerss

fa4e2a5

Fix wp-cli unit tests – do not minify wp-config.php

f4b8189

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

0848f5a

adamziel changed the base branch from trunk to playground-boot-protocol May 23, 2024 04:20

adamziel changed the base branch from playground-boot-protocol to trunk May 23, 2024 04:21

adamziel marked this pull request as draft May 23, 2024 16:35

adamziel added 8 commits May 23, 2024 12:39

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

59be092

Resolve last conflicts

656f167

Remove unrelated md changes

65fac4c

Use bootWordPress() in all the WordPress-related tests

de4c9ab

Fix unit tests

4e74a60

Adjust unit tests

9a06a61

Fix reset-data unit test

966dee7

Fix sql.spec.ts

23dc5c1

adamziel marked this pull request as ready for review May 23, 2024 17:48

adamziel requested review from brandonpayton and bgrgicak May 23, 2024 17:49

bgrgicak reviewed May 24, 2024

View reviewed changes

adamziel added 2 commits May 28, 2024 11:43

Merge branch 'trunk' into produce-minified-wp-without-sqlite-plugin

21e04cc

Lint

9ad7827

Create the /wordpress/wp-content/mu-plugins directory when attempting…

d9f5cdf

… to writeFile to it

adamziel merged commit daf9c52 into trunk May 28, 2024
5 checks passed

adamziel deleted the produce-minified-wp-without-sqlite-plugin branch May 28, 2024 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WordPress Build: Use Playground CLI to produce minified WordPress build (without the SQLite integration plugin) #1426

WordPress Build: Use Playground CLI to produce minified WordPress build (without the SQLite integration plugin) #1426

adamziel commented May 18, 2024 •

edited

Loading

brandonpayton commented May 21, 2024 •

edited

Loading

adamziel commented May 22, 2024

brandonpayton commented May 22, 2024

bgrgicak left a comment •

edited

Loading

adamziel commented May 28, 2024 •

edited

Loading

adamziel commented May 28, 2024

WordPress Build: Use Playground CLI to produce minified WordPress build (without the SQLite integration plugin) #1426

WordPress Build: Use Playground CLI to produce minified WordPress build (without the SQLite integration plugin) #1426

Conversation

adamziel commented May 18, 2024 • edited Loading

Testing instructions

brandonpayton commented May 21, 2024 • edited Loading

adamziel commented May 22, 2024

brandonpayton commented May 22, 2024

bgrgicak left a comment • edited Loading

Choose a reason for hiding this comment

adamziel commented May 28, 2024 • edited Loading

adamziel commented May 28, 2024

adamziel commented May 18, 2024 •

edited

Loading

brandonpayton commented May 21, 2024 •

edited

Loading

bgrgicak left a comment •

edited

Loading

adamziel commented May 28, 2024 •

edited

Loading