Proposed 1.1.0-b2 #2566
Merged
Proposed 1.1.0-b2 #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: RIPD-1575. Fix argument passing to runner. Allow multiple unit test selectors to be passed via --unittest argument. Add optional integer priority value to test suite list. Fix several failing manual tests. Update CLI usage message to make it clearer.
* Enable the `suggest-override` warning for gcc * Fix all functions that were flagged by that warning
Fixes: XRPLF#2521 Copy ctor missed one member. Also added move since we have some rvalues passed around here.
Jenkins Build SummaryBuilt from this commit Built at 20180601 - 20:47:36 Test Results
|
Codecov Report
@@ Coverage Diff @@
## develop #2566 +/- ##
===========================================
+ Coverage 70.78% 70.84% +0.05%
===========================================
Files 703 703
Lines 54626 54685 +59
===========================================
+ Hits 38666 38739 +73
+ Misses 15960 15946 -14
Continue to review full report at Codecov.
|
|
With Michael's changes, my PRs should just require an approval from a Ripple team member to run the Jenkins CI instead of closing and reopening my PRs, right? This would fall under the "untrusted" PRs from what I understand. |
|
@JoeLoser for new PRs, yes...they will be able to build with manual approval (at least that's the intent). For existing PRs, possibly if/when there are new changes pushed (we'll have to see if that works) |
|
@mellery451 sounds good. Thanks for your work! I'm sure it will make life easier for other team members as well with my changes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.