make eth_call not timeout during UpdateM1 #595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The value of timeout for a single call is 5 seconds now.
When the system is extremely slow, such as the CPU is exhausted, the function
Call
will returnerr="execution aborted (timeout = 5s)"
. This is OK for normal transactions. But when we call the functionUpdateM1
:if
UpdateM1
returns timeout error, then the node will exit bylog.Crit
. The functionUpdateM1
calls the function of contract MasternodeVotingSMC(xdc0000000000000000000000000000000000000088). So this PR change the timeout value for the transactions ofMasternodeVotingSMC
to zero which means infinite.Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that