Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make MasternodeVotingSMC tx never timeout #598

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Aug 2, 2024

Proposed changes

The value of timeout for a single call is 5 seconds now.

func (s *PublicBlockChainAPI) Call(ctx context.Context, args CallArgs, blockNrOrHash *rpc.BlockNumberOrHash, overrides *StateOverride) (hexutil.Bytes, error) {
        // ......
	result, _, failed, err, vmErr := DoCall(ctx, s.b, args, *blockNrOrHash, overrides, vm.Config{}, 5*time.Second, s.b.RPCGasCap())
	if err != nil {
		return nil, err
	}
	// ......
}

When the system is extremely slow, such as the CPU is exhausted, the function Call will return err="execution aborted (timeout = 5s)". This is OK for normal transactions. But when we call the function UpdateM1:

// in function WriteBlockWithState
err := bc.UpdateM1()
if err != nil {
    log.Crit("Error when update masternodes set. Stopping node", "err", err, "blockNum", block.NumberU64())
}

// in function reorg
err := bc.UpdateM1()
if err != nil {
    log.Crit("Error when update masternodes set. Stopping node", "err", err, "blockNumber", newChain[i].NumberU64())
}

if UpdateM1 returns timeout error, then the node will exit by log.Crit. The function UpdateM1 calls the function of contract MasternodeVotingSMC(xdc0000000000000000000000000000000000000088). So this PR change the timeout value for the transactions of MasternodeVotingSMC to zero which means infinite.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@liam-lai
Copy link
Collaborator

liam-lai commented Aug 2, 2024

tested with pr #595.

@liam-lai liam-lai merged commit 824c531 into XinFinOrg:master Aug 2, 2024
17 checks passed
@gzliudan gzliudan deleted the updatem1-timeout branch August 2, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants