Whammy Pitch Modulation #812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and added pitch changes when FiveFretPlayer moves whammy bar.
…s added back into UI.
…rimental Preview with notice text. Added localization for text.
…ting. When enabled, adds the Experimental tab under All Settings. Added an icon for this tab if ever shown at the top.
…ded missing localizations for setting descriptions. Added warning text about possible desync.
|
I have updated this PR to move the Whammy settings under Experimental Features. This means that the following PR would need to be merged before this one can be merged: |
…ble under All Settings. Added dialog shown when entering Experimental Features. This dialog is shown once per launch and can also be marked to not show again. Added new localized strings for the dialog and title. Removed old localized strings for the previous setting to show and hide the Experimental section.
# Conflicts: # Assets/Script/Settings/SettingsManager.cs # Assets/Settings/Localization/Settings Shared Data.asset # Assets/Settings/Localization/Settings_en-US.asset
…ng updates to feature/Experimental,
|
Updated to incorporate changes made in #815. |
# Conflicts: # Assets/Settings/Localization/Main Shared Data.asset # Assets/Settings/Localization/Main_en-US.asset # Assets/Settings/Localization/Settings Shared Data.asset # Assets/Settings/Localization/Settings_en-US.asset
# Conflicts: # Assets/Settings/Localization/Settings Shared Data.asset # Assets/Settings/Localization/Settings_en-US.asset
# Conflicts: # Assets/Script/Settings/SettingsManager.Settings.cs # Assets/Script/Settings/SettingsManager.cs
…stom Minis fork to latest commit)
Still shows the library as if the sort swapped to By-Name, but the underlying sort type will stay as Playable Songs
+ Move Instrument set check to GetPlayableSongs() function. + Replace GetSortedCategory()'s `_playable` usage with a GetPlayableSongs() call. + Privatize GetPlayableSongs() + Fix Playable Songs sort not appearing as an option with zero active players
Down with LINQ!!
* Move "Insensity" instrument icon shortcut to Right-Click Temporary measure until a better sorting/filtering system is in place Replaces Left-Click with prior broad filter behavior * Address incorrect intensity overrides + Won't force a cache update, but a clear cache is required to apply the fix.
* Hotfix: Allow changing library sort when only one sort header is present, prevent *Go To* instead when there aren't enough headers * Simplify HasSortHeaders logic
Instead of inserting at the start and shifting everything over, add views in direct order. Why we didn't do this before... couldn't tell ya.
* Found an unrelated missing quote in the localization file * Setting to disable SP phrases in practice mode * Fixed display of Vocals lyric color when SP is disabled * Correct setting description
…s added back into UI.
Closed
|
Replacing this PR with #846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pitch bending whammy support back in.
I have updated this PR to move the Whammy settings under Experimental Features. This means that the following PR would need to be merged before this one can be merged:
#815
I submitted another PR for YARG.Core to support these changes and I will open a discussion in this feature request:
#786
Here are the changes I implemented to restore this feature:
Added WhammyPitch (float) to StemSettings
Added OnWhammyPitchChange to StemSettings
In StemChannel subscribed to OnWhammyPitchChange at the same location volume change is called
In GlobalAudioHandler added Get/SetWhammyPitchSetting
In StemState added SetWhammyPitch.
In SettingsManager.Settings uncommented UseWhammyFx setting and UseWhammyFxChange.
In SettingsManager.Settings uncommented WhammyPitchShiftAmount setting and WhammyPitchShiftAmountChange.
In GameManager.Audio added ChangeStemWhammyPitch
In FiveFretPlayer added SetStemWhammyPitch
In FiveFretPlayer called SetStemWhammyPitch in override for OnInputQueued when WhammyFactor is updated.
In GlobalAudioHandler changed WHAMMY_FFT_DEFAULT to 512 to try and reduce latency between guitar track and other tracks when pitch change is enabled.