Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GitHub Actions for creating Takajo release artifacts #84

Merged
merged 4 commits into from
Jan 14, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Dec 30, 2023

What Changed

  • Created GitHub Actions to create following Takajo release artifacts
    • takajo-2.x.x-linux.zip(takajo/mitre-attack.json)
    • takajo-2.x.x-mac.zip(takajo/mitre-attack.json)
    • takajo-2.x.x-win.zip(takajo/mitre-attack.json/pcrd64.dll)
    • README-2.x.x-English.pdf
    • README-2.x.x-Japanese.pdf

How to use

  1. Run workflow
スクリーンショット 2023-12-30 21 41 05
  1. Download artifact
スクリーンショット 2023-12-30 21 41 25
  1. Unzip artifacts
スクリーンショット 2023-12-30 22 16 26

Test

I checked GitHub Actions in my repository and confirmed that the following zip was created.
https://github.com/fukusuket/takajo-fukusuket/actions/runs/7364252562

release-artifact.zip

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the enhancement New feature or request label Dec 30, 2023
@fukusuket fukusuket self-assigned this Dec 30, 2023
@fukusuket fukusuket marked this pull request as ready for review December 30, 2023 13:21
@fukusuket fukusuket changed the title feat: add GitHub actions for create release artifacts feat: add GitHub actions for create Takajo release artifacts Dec 30, 2023
@fukusuket fukusuket changed the title feat: add GitHub actions for create Takajo release artifacts feat: add GitHub Actions for creating Takajo release artifacts Dec 30, 2023
@fukusuket
Copy link
Collaborator Author

fukusuket commented Dec 30, 2023

Unfortunately, intel-mac binaries cannot be created because intel-mac is not supported as shown below... :(
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@fukusuket
Copy link
Collaborator Author

fukusuket commented Jan 13, 2024

After some research, I found that Nim supports cross-compilation as follows :)
https://nim-lang.org/docs/nimc.html#crossminuscompilation

I tried adding the following compile options for Intel mac!

nimble build -d:release --threads:on --os:macosx --cpu:amd64

@YamatoSecurity
Could you please confirm whether it works on Intel Mac?🙏 release-artifact.zip is attached below.
release-artifact.zip

スクリーンショット 2024-01-13 9 41 47

@YamatoSecurity
Copy link
Collaborator

@fukusuket That's great news! Thanks, I checked it and it works no problem.
Just one thing, could you change the artifacts folder to release-binaries? I think it will be easier to understand for non-programmers.

@fukusuket
Copy link
Collaborator Author

@YamatoSecurity
Thank you so much for checking! I have changed to release-binaries :)

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thank you!!

@YamatoSecurity YamatoSecurity merged commit bb759ad into main Jan 14, 2024
2 checks passed
@fukusuket fukusuket deleted the add-github-actions-for-create-release-binary branch January 14, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants