-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iron: upstream package updates #4
Conversation
Thanks for the PR. Could you please rebase on |
I'm especially confused about 1aa6c57. |
977b371
to
054cf35
Compare
Alright, I rebased onto |
aa23c95
to
0ec37d6
Compare
Thanks @jimmy-mcelwain. I've squashed your commits (and a single fixup from my side). |
Could you please let me know which upstream Iron release you took these package versions from? Then we can update the commit comment (on 0ec37d6) and merge this. |
I misunderstood, I didn't take the versions from any single release of iron. In many cases I just pulled the latest release for iron from each package individually. I can update it to match a single released version (I will look at 20240423), but to do so I may have to also rebase some of our forked branches onto newer upstream versions, e.g. our fork of ament_cmake is based on 2.0.4 whereas iron release 20240423 targets uses 2.0.5. Also, the micro-ros releases don't appear to target specific releases/commits when pulling packages, it just pulls the newest version from each iron branch if I am reading the .repos file correctly. So I may just target the latest released version for each repo that they target if that seems reasonable. Sorry for the confusion |
First: lets not make things more complex than they already are. I suggest we keep the list of pkgs you already identified, including the versions in this PR. Having written that: we loosely follow calendar versioning here, and the fact upstream tags their We can't completely limit ourselves to upstream releases as we sometimes need additional (unreleased) fixes. For future updates we'll want to look at / stick to upstream release tags. For now we'll keep your PR as-is. |
I suggest we update the commit comment to instead mention the date at which you checked upstream. |
oh, and to clarify:
When I write upstream, I don't necessarily mean micro-ROS. Technically we use micro-ROS, but quite a few packages come from 'regular' ROS 2. I should've clarified. |
0ec37d6
to
beb0e97
Compare
Okay. I last did a complete check of the upstream branches yesterday, so I marked it as such through the commit message and pushed it back up. |
Test build: here. Seems to build. Thanks @jimmy-mcelwain 👍 |
Updates packages to pull from newer versions for iron