Add new Alert type for Spikes in Single Metric Aggregations #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds on query_keys
…lds on query_keys
|
Awesome work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alert which fires off of rises/drops in the average value of a metric (as well as any other aggregation supported by the Metric Aggregation rule)
This piggybacks off of all of the work done in Spike alerts (which let us consider relative changes but only of counts) and Metric Aggregation alerts (which let us consider aggregated values but only against predefined thresholds)
In addition, I added support for aggregation of scripted metrics. This is currently only supported in the new Spike Aggregation alert but could be easily extended to Metric Aggregations as well.