corrected spike aggregation support for avg,min,max #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test are failing |
|
Can you resolve conflicts please :) |
|
@nsano-rururu updated the branch, builds passing. |
|
Merged into elastalert2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello!
This is hopefully the only followup to #2052 - one of our analysts noticed that the values outputted in the
avgspike aggregation alert didn't make sense for percentage values (greater than 1.0).Indeed, passing aggregated metrics through the spike tracker would only alert based on the total count over the timeframe... this makes sense for
sumorvalue_countaggregations but nothing else. This is an issue for other aggregations if your EAconfig.yamltimeframe is shorter than the Spike Aggregation's timeframe.I extended logic in the spike & event handler to support existing Spike alerts while also ferrying average, min, and max calculations over the EventWindow for Spike Aggregation alerts