remove remove_tag_from_job_id #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 4, 2015 21:13
This isn't really right because it overrides arguments, but that means we're passing in multiple forms of the same information, so I got stuck here figuring out how to refactor. That will come next.
It all comes from the same place. This is kind of messy but this call stack is sort of complicated and I've done what I came here to do, so I'ma stop here.
|
ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the misguided concept 'tag' from the code base a while ago, but didn't do this part since it was more than I wanted to tackle at the time.
Anyway, this re-enforces a single way to deal with translation between fully assembled job_ids and their constituent parts. I think simplification in this complex workflow is quite important.