Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove remove_tag_from_job_id #22

Merged
merged 11 commits into from
Nov 10, 2015
Merged

remove remove_tag_from_job_id #22

merged 11 commits into from
Nov 10, 2015

Commits on Nov 5, 2015

  1. Docstring

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    77f420c View commit details
    Browse the repository at this point in the history

  2. Add deformat_job_id()

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    3ef2a5c View commit details
    Browse the repository at this point in the history

  3. Kill a remove_tag_from_job_id() and use deformat_job_id()

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    72545b0 View commit details
    Browse the repository at this point in the history

  4. Use deformat_job_id some more

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    f98bcaf View commit details
    Browse the repository at this point in the history

  5. Remove another remove_tag_from_job_id()

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    9638391 View commit details
    Browse the repository at this point in the history

  6. Remove another. 

    This isn't really right because it overrides arguments, but that means
we're passing in multiple forms of the same information, so I got stuck
here figuring out how to refactor. That will come next.
    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    1b6c099 View commit details
    Browse the repository at this point in the history

  7. Catch right exception. Confirmed with manual testing.

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    e7d3e80 View commit details
    Browse the repository at this point in the history

  8. Correct cockney accent

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    a01069a View commit details
    Browse the repository at this point in the history

  9. Turns out I don't need to mess with marathon_jobid at all. 

    It all comes from the same place. This is kind of messy but this call stack is
sort of complicated and I've done what I came here to do, so I'ma stop here.
    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    3570c03 View commit details
    Browse the repository at this point in the history

  10. Remove another

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    c3a72b8 View commit details
    Browse the repository at this point in the history

  11. remove_tag_from_job_id is dead

    Tyler Roscoe committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    acd7bad View commit details
    Browse the repository at this point in the history