Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

P2-674 Adds exports needed for the apply button #1127

Closed
wants to merge 14 commits into from
Closed

P2-674 Adds exports needed for the apply button #1127

wants to merge 14 commits into from

Conversation

hansjovis
Copy link
Contributor

Summary

This PR can be summarized in the following changelog entry:

  • [schema-blocks] Adds the RenderEditProps and RenderSaveProps as package exports.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

hansjovis and others added 14 commits March 18, 2021 09:46
@hansjovis hansjovis added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 29, 2021
@hansjovis hansjovis changed the title First iteration of index.ts exports. P2-674 Adds exports needed for the apply button Mar 29, 2021
andizer
andizer suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@andizer andizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR done

packages/schema-blocks/src/core/validation/BlockValidationResult.ts Show resolved Hide resolved
packages/schema-blocks/src/functions/presenters/SidebarWarningPresenter.ts Show resolved Hide resolved
packages/schema-blocks/src/instructions/blocks/InnerBlocks.tsx Show resolved Hide resolved
@andizer andizer mentioned this pull request Mar 29, 2021
Merged
3 tasks
@hansjovis
Copy link
Contributor Author

Closed in favour of #1132

@hansjovis hansjovis closed this Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andizer andizer andizer requested changes

Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hansjovis @andizer @increddibelly