This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
P2-704 Same Post and Job titles do not trigger red analysis #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ascript into P2-704-same-post-and-job-title
hansjovis
added
the
changelog: non-user-facing
increddibelly
suggested changes
Mar 26, 2021
| @@ -1,7 +1,7 @@ | |||
| import { ReactElement } from "react"; | |||
| import { createElement } from "@wordpress/element"; | |||
| import { BlockInstance } from "@wordpress/blocks"; | |||
| import BlockSuggestions from "../../blocks/BlockSuggestions"; | |||
| import { RequiredBlocks as BlockSuggestions } from "../../blocks/BlockSuggestions"; | |||
| @@ -1,6 +1,6 @@ | |||
| import attributeExists from "./attributeExists"; | |||
| import attributeNotEmpty from "./attributeNotEmpty"; | |||
| import getInvalidInnerBlocks from "./innerBlocksValid"; | |||
| import { validateInnerBlocks as getInvalidInnerBlocks } from "./innerBlocksValid"; | |||
There was a problem hiding this comment.
why the rename?
Suggested change
| import { validateInnerBlocks as getInvalidInnerBlocks } from "./innerBlocksValid"; | |
| import { validateInnerBlocks } from "./innerBlocksValid"; |
| @@ -6,6 +6,7 @@ import recurseOverBlocks from "../blocks/recurseOverBlocks"; | |||
| import { getInnerblocksByName } from "../innerBlocksHelper"; | |||
| import logger from "../logger"; | |||
| import isValidResult from "./isValidResult"; | |||
There was a problem hiding this comment.
there's still a default export remaining here.
| @@ -3,10 +3,10 @@ import { BlockEditProps, BlockConfiguration } from "@wordpress/blocks"; | |||
| import { createElement } from "@wordpress/element"; | |||
| import { SelectControl } from "@wordpress/components"; | |||
| // Internal imports. | |||
There was a problem hiding this comment.
Suggested change
| // Internal imports. |
|
|
||
| import VariableTagRichText from "./VariableTagRichText"; | ||
|
|
||
| export { VariableTagRichText }; |
There was a problem hiding this comment.
why import the rest if we're not exporting them?
There was a problem hiding this comment.
For the BlockInstruction.register side effects.
Without them the block instructions are not registered.
There was a problem hiding this comment.
But yes, I will export them all.
| import "./Schema"; | ||
| import SchemaInstruction from "./Schema"; | ||
|
|
||
| // Need to export something for the side-effects of the imports to work... |
There was a problem hiding this comment.
dank voor dit comment!
kunnen we de side effects expliciet maken / aanroepen?
| @@ -1,13 +1,21 @@ | |||
| import { dispatch, select } from "@wordpress/data"; | |||
| import { BlockInstance } from "@wordpress/blocks"; | |||
|
|
|||
| import { removeBlock, restoreBlock, getBlockType } from "../../src/functions/BlockHelper"; | |||
| import { removeBlock, restoreBlock, getBlockType, getHumanReadableBlockName } from "../../src/functions/BlockHelper"; | |||
There was a problem hiding this comment.
rename the file from BlocksHelper.test.ts to BlockHelper.test.ts (singular)
| @@ -1,8 +1,7 @@ | |||
| import { BlockValidation, BlockValidationResult } from "../../../src/core/validation"; | |||
| import getWarnings, { createAnalysisMessages, sanitizeBlockName } from "../../../src/functions/presenters/SidebarWarningPresenter"; | |||
| import getWarnings, { createAnalysisMessages } from "../../../src/functions/presenters/SidebarWarningPresenter"; | |||
There was a problem hiding this comment.
can we un-default export the getWarnings?
3 tasks
|
Closed in favour of #1129. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
BlockValidationResults itself, rather than a separate result -> warning map.Test instructions
This PR can be tested by following these steps:
Impact check
UI changes
Quality assurance
Fixes #