Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Added title block instruction. #1129

Merged
merged 6 commits into from
Mar 30, 2021
Merged

Added title block instruction. #1129

merged 6 commits into from
Mar 30, 2021

Conversation

hansjovis
Copy link
Contributor

@hansjovis hansjovis commented Mar 29, 2021 •
edited
Loading

Summary

This PR can be summarized in the following changelog entry:

  • [schema-blocks] Adds a Title block instruction.

Relevant technical choices:

Test instructions

This PR can be tested by following these steps:

Impact check

  • This PR affects the following parts of the plugin, which may require extra testing:
    *

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@hansjovis hansjovis added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Mar 29, 2021
@hansjovis hansjovis marked this pull request as ready for review March 29, 2021 15:03
@hansjovis hansjovis mentioned this pull request Mar 29, 2021
Closed
3 tasks
andizer
andizer approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@andizer andizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR okay. One minor thing that I can commit myself/

packages/schema-blocks/src/instructions/blocks/Title.tsx Outdated Show resolved Hide resolved
andizer
andizer approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@andizer andizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👍

@andizer andizer merged commit f3593ea into develop Mar 30, 2021
@andizer andizer deleted the P2-704-title-block branch March 30, 2021 13:07
@increddibelly increddibelly added this to the 16.2 milestone Apr 6, 2021
@johannadevos johannadevos added changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog and removed changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andizer andizer andizer approved these changes

Assignees
No one assigned
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Milestone
16.2
Development

Successfully merging this pull request may close these issues.
4 participants
@hansjovis @andizer @increddibelly @johannadevos