Optimise retain_variable_keys function. #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevalk
pushed a commit
that referenced
this pull request
Sep 28, 2014
Optimise retain_variable_keys function. props @dannyvankooten
|
@dannyvankooten Only just now had time to review this and seems like a very sensible optimization. Thanks! |
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
17 tasks
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Screeshots updated. Sparkles icon updated.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Fix color values.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Snapshot updated.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Fix button press.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Fix snapshots.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Fix linting issues.
mykola
added a commit
that referenced
this pull request
Jun 14, 2024
…sparkle buttons) #1624 Return solid border.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing around with XHProf I noticed
WPSEO_Option_Titles::retain_variable_keyswas responsible for close to 4% of the execution time of the rendered page.Looking at the function, I noticed a check could be done to prevent even going into the second loop which would have no consequences, AFAIK.
Current situation
New situation (with this PR)
Pinging @jrfnl as she probably knows best what the consequences are for this seemingly simple change.