Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 'blue' to 'indigo' in all AI components #21441

Merged
merged 9 commits into from
Jun 18, 2024

Conversation

mykola
Copy link
Contributor

@mykola mykola commented Jun 14, 2024

Context

  • The AI assessment sparkle button color changed from 'blue' to 'indigo'.

Summary

This PR can be summarized in the following changelog entry:

  • Updates the styling of AI assessments fixes buttons.

Relevant technical choices:

  • Just change color.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Have Yoast SEO and Yoast SEO Premium activated.
  • Open or create a new post.
  • Use the block editor.
  • Add enough content and also add a focus keyphrase. Ensure that the keyphrase is not included in the first paragraph/introduction and that it isn't used more than once in the content.
  • Open the Premium SEO analysis tab in the Yoast Premium SEO > SEO or in the Yoast SEO sidebar.
SCR-20240604-oftc
  • Check that the _Keyphrase in introduction and Keyphrase density and Keyphrase distribution assessments aren't green and show the sparkle button of the AI assessments fixes project.
  • Check that the FIx with AI button background is fit the Design and 'to-indigo-50 (#eef2ff)' color is used.
  • Check that the FIx with AI button hover background is fit the Design and 'to-indigo-100 (#e0e7ff)' color is used.
  • Check that the FIx with AI button image is fit the Design.
  • Click the FIx with AI button and make sure that active state background is fit the Design and 'to-indigo-500 (#6366f1)' color is used.
  • Check that the FIx with AI button active state image is fit the Design and white color is used.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

  • Please check any other Toast message that it still the same.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched of
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #1624

Copy link

@mykola Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 4804bf04b2fb986700759e687389b98fe83b9c24

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 48.407%

Totals Coverage Status
Change from base Build e123e7850cebdcca595fd3e91af04aaf64a5394b: -0.003%
Covered Lines: 25082
Relevant Lines: 53676

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build d68d14ed80bed314e18d3324ad3acb87a6230147

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 48.416%

Totals Coverage Status
Change from base Build e123e7850cebdcca595fd3e91af04aaf64a5394b: 0.006%
Covered Lines: 25086
Relevant Lines: 53680

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 0e4197cef1bea137224d6df36e523b6bbc71f248

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 48.416%

Totals Coverage Status
Change from base Build e123e7850cebdcca595fd3e91af04aaf64a5394b: 0.006%
Covered Lines: 25086
Relevant Lines: 53680

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 7331a47fcf61662e26ffa3ec8fb664cd33adb6f5

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-32.2%) to 16.211%

Totals Coverage Status
Change from base Build e123e7850cebdcca595fd3e91af04aaf64a5394b: -32.2%
Covered Lines: 2863
Relevant Lines: 19910

💛 - Coveralls

@mykola mykola marked this pull request as ready for review June 14, 2024 12:50
@Jordi-PV Jordi-PV added UI change PRs that result in a change in the UI innovation Innovative issue. Relating to performance, memory or data-flow. labels Jun 14, 2024
@Jordi-PV
Copy link
Contributor

Jordi-PV commented Jun 14, 2024

Hi @mykola, if you check the innovation project checkbox, then the innovation label should be added.
SCR-20240614-pftr.

The same goes for the UI change label. I will add them :)
SCR-20240614-phar

And don't forget to add your hours to the WBSO document 🙂

@Jordi-PV
Copy link
Contributor

And I would also update the changelog for this PR as:

  • Updates the styling colors of AI assessments fixes buttons.

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build aac0cce1cd27727487b139e0d627a75f1d1ec2b1

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.41%

Totals Coverage Status
Change from base Build e123e7850cebdcca595fd3e91af04aaf64a5394b: 0.0%
Covered Lines: 25084
Relevant Lines: 53678

💛 - Coveralls

@Jordi-PV Jordi-PV merged commit 4041cc8 into feature/fix-assessments Jun 18, 2024
17 checks passed
@Jordi-PV Jordi-PV deleted the 1624-change-blue-to-indigo branch June 18, 2024 08:29
@Jordi-PV Jordi-PV modified the milestones: 23.0, feature/fix-assessments Jun 18, 2024
@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 1, 2024
@mhkuu mhkuu changed the title Change 'blue' to 'indigo' in all AI branded components (Toast and AI … Changes 'blue' to 'indigo' in all AI components Jul 16, 2024
@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow. UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants