Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merges the feature branch feature/fix-assessments into trunk #21480

Merged
merged 259 commits into from
Jul 16, 2024

Conversation

mhkuu
Copy link
Contributor

@mhkuu mhkuu commented Jul 16, 2024

Context

  • We want to prepare the 23.2 release by merging the feature branch feature/fix-assessments to trunk.

Summary

This PR can be summarized in the following changelog entry:

  • Merges the feature branch feature/fix-assessments into trunk.

Relevant technical choices:

This PR combines the following individual PRs:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Smoke the the AI Optimize functionality.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • See the individual PRs.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Jordi-PV and others added 30 commits May 1, 2024 11:14
…ents' of github.com:Yoast/wordpress-seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
… is used to track whether there is an active AI Fixes button so we can display the button background color and the icon color differently when they are pressed. This is only relevant in Premium. In Free, this logic is irrelevant because clicking on the button will only display the Upsell modal.
…seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 16, 2024
@mhkuu mhkuu added this to the 23.2 milestone Jul 16, 2024
@mhkuu mhkuu requested a review from a team as a code owner July 16, 2024 07:21
Copy link

@mhkuu Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

/* Internal dependencies */
import { ModalContent } from "./modal-content";
import { getAllBlocks } from "../../helpers/getAllBlocks";
import { ReactComponent as LockClosed } from "../../../images/lock-closed.svg";
Copy link
Contributor Author

@mhkuu mhkuu Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this icon is loaded as an SVG 🤔 See #21450 -- I've created #21482 to check this.

Copy link
Contributor Author

@mhkuu mhkuu Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this deprecation as an "other" changelog? See #21465.

@mhkuu
Copy link
Contributor Author

mhkuu commented Jul 16, 2024

#21418 seems to have been removed in #21415 -- this needs to be re-applied. Issue created: #21481.

@mhkuu mhkuu merged commit 30775d9 into trunk Jul 16, 2024
51 checks passed
@mhkuu mhkuu deleted the feature/fix-assessments branch July 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants