-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AI Optimize upsell introduction modal #21417
Adds AI Optimize upsell introduction modal #21417
Conversation
@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
php fix cs
914f9a9
to
476e988
Compare
Pull Request Test Coverage Report for Build b6441c93c56b8af7135cb50d377d4dd398e95d44Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acc: ✅
CR: ❌ Not strictly functional, but I'd correct all the instances of the typo assesments
before merging 🙂
ef8e260
to
9896b0f
Compare
fix tabs disable outdated introduction modal
9896b0f
to
bca585a
Compare
src/introductions/application/ai-generate-titles-and-descriptions-introduction-upsell.php
Outdated
Show resolved
Hide resolved
CR: ✅, fixed the typos 👍 |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Without this PR, go to
Yoast SEO
->Settings
or other yoast admin page.If you are not seeing the old introduction modal for the ai generator of titles and descriptions, it means you already seen it, and no need to do anything. Otherwise you should see the old introduction modal.
Checkout this PR and refresh the page
You should see the new introduction modal for the AI fix assessments feature.
Dissmiss the modal or close it, refresh and check you don't see it again.
Edit a post, add focus keyphrase and at least 300 words of content.
Click on the
Use AI
button in the Search preview and check you get the upsell modal for the AI generator of titles and descriptions.Go to
SEO analysis
and click on the sparkle icon. Check you are getting the introduction modal for AI fix assessments.Create new environment or remove
_yoast_wpseo_introductions
from your user meta.Go to one of Yoast SEO admin pages like settings or general.
Check you see the introduction modal for AI fix assessments without the consent check box.
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #