Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds AI Optimize upsell introduction modal #21417

Merged

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented May 30, 2024

Context

  • We want to replace the introduction modal content with the introduction for the new AI fix assessment feature
  • We want to create a modal for consent only.

Summary

This PR can be summarized in the following changelog entry:

  • Update and separate feature introduction modal and ai consent modal.

Relevant technical choices:

  • I kept the modal for ai generated title and description for future carousel.
  • Video, thumbnail and copy will come later.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Without this PR, go to Yoast SEO->Settings or other yoast admin page.

  • If you are not seeing the old introduction modal for the ai generator of titles and descriptions, it means you already seen it, and no need to do anything. Otherwise you should see the old introduction modal.

  • Checkout this PR and refresh the page

  • You should see the new introduction modal for the AI fix assessments feature.

  • Dissmiss the modal or close it, refresh and check you don't see it again.

  • Edit a post, add focus keyphrase and at least 300 words of content.

  • Click on the Use AI button in the Search preview and check you get the upsell modal for the AI generator of titles and descriptions.

  • Go to SEO analysis and click on the sparkle icon. Check you are getting the introduction modal for AI fix assessments.

  • Create new environment or remove _yoast_wpseo_introductions from your user meta.

  • Go to one of Yoast SEO admin pages like settings or general.

  • Check you see the introduction modal for AI fix assessments without the consent check box.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@vraja-pro vraja-pro added UI change PRs that result in a change in the UI changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels May 30, 2024
Copy link

@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@vraja-pro vraja-pro changed the base branch from trunk to feature/fix-assessments May 30, 2024 11:39
 php fix cs
@vraja-pro vraja-pro force-pushed the ai-fix-assesment-upsell-introduction-model branch from 914f9a9 to 476e988 Compare May 31, 2024 08:50
@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build b6441c93c56b8af7135cb50d377d4dd398e95d44

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 40 (60.0%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+27.5%) to 34.51%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/components/content.js 0 2 0.0%
src/introductions/application/ai-fix-assessments-upsell.php 16 20 80.0%
packages/js/src/ai-assessment-fixes/components/modal-content.js 2 12 16.67%
Files with Coverage Reduction New Missed Lines %
packages/js/src/ai-generator/components/modal-content.js 2 0.0%
src/introductions/application/ai-generate-titles-and-descriptions-introduction-upsell.php 3 0.0%
Totals Coverage Status
Change from base Build d3ba57ee53574fe573a3d2dcd89b260e162218a4: 27.5%
Covered Lines: 5167
Relevant Lines: 15392

💛 - Coveralls

@mhkuu mhkuu added this to the feature/fix-assessments milestone May 31, 2024
@vraja-pro vraja-pro assigned vraja-pro and unassigned vraja-pro May 31, 2024
@pls78 pls78 changed the title Ai fix assessment upsell introduction model Ai fix assessment upsell introduction modal Jun 4, 2024
Copy link
Member

@pls78 pls78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acc: ✅
CR: ❌ Not strictly functional, but I'd correct all the instances of the typo assesments before merging 🙂

@vraja-pro vraja-pro force-pushed the ai-fix-assesment-upsell-introduction-model branch from ef8e260 to 9896b0f Compare June 5, 2024 08:39
fix tabs

disable outdated introduction modal
@vraja-pro vraja-pro force-pushed the ai-fix-assesment-upsell-introduction-model branch from 9896b0f to bca585a Compare June 5, 2024 09:59
@mhkuu
Copy link
Contributor

mhkuu commented Jun 5, 2024

CR: ✅, fixed the typos 👍

@mhkuu mhkuu merged commit 3f99d27 into feature/fix-assessments Jun 5, 2024
34 checks passed
@mhkuu mhkuu deleted the ai-fix-assesment-upsell-introduction-model branch June 5, 2024 10:39
@mhkuu mhkuu changed the title Ai fix assessment upsell introduction modal Adds AI Optimize upsell introduction modal Jul 16, 2024
@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow. UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants