-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds lock icon to AI buttons #21450
Adds lock icon to AI buttons #21450
Conversation
@mykola Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
…1622 Fix linting and snapshots.
Pull Request Test Coverage Report for Build 59e18d690d1ad53f7d13bcf0a1fc3302e54bd4fdDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good and works 👍 . @mykola should we maybe consider adding the CSS for the fix/assessments project in a separate file (ex. ai-fix-assessments.css
) instead of adding it in the ai-generator.css file? 🤔
Pull Request Test Coverage Report for Build 821fb4eb9314416fda4fc18946e9751e55ccb142Details
💛 - Coveralls |
…1622 Move into separate file.
…ress-seo into 1622-ai-assessment-lock-icon
…22-ai-assessment-lock-icon
Pull Request Test Coverage Report for Build d3fa9c0024e75451fa0abf1b1c307f627186421dDetails
💛 - Coveralls |
Is there a reason why we're not using the |
…1622 Update threshold errors
Pull Request Test Coverage Report for Build d29510361b44bfcf48dad0c68381ee1959378b7eDetails
💛 - Coveralls |
Nice job @mykola! It works like a charm 🙌 |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Have Yoast SEO activated and Yoast SEO Premium deactivated.
Open or create a new post.
Use the block editor.
Add enough content and also add a focus keyphrase. Ensure that the keyphrase is not included in the first paragraph/introduction and that it isn't used more than once in the content.
Open the SEO analysis tab.
Check that the Keyphrase density assessments aren't green and show the sparkle button of the AI assessments fixes project.
Check that the FIx with AI button fit the Design and lock icon is present.
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Innovation
innovation
label.Fixes #1622