Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables all AI buttons other than the one currently in use #21418

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

pls78
Copy link
Member

@pls78 pls78 commented May 30, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Disables AI Fix buttons other than the one that is currently highlighted.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Follow the instructions in the corresponding Premium PR

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • N/A

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/wordpress-seo-premium/issues/4307

@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 30, 2024
@pls78 pls78 added this to the 22.9 milestone May 30, 2024
Copy link

@pls78 Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@coveralls
Copy link

coveralls commented May 31, 2024

Pull Request Test Coverage Report for Build 8e8870275803c8ea349c02a1754004ba1a56abc0

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3706 unchanged lines in 106 files lost coverage.
  • Overall coverage decreased (-4.3%) to 48.348%

Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/builders/indexable-home-page-builder.php 1 98.0%
src/builders/indexable-term-builder.php 1 99.15%
src/context/meta-tags-context.php 1 28.29%
src/generators/breadcrumbs-generator.php 1 64.23%
src/generators/schema/webpage.php 1 90.32%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.49%
src/integrations/watchers/indexable-ancestor-watcher.php 1 98.41%
Totals Coverage Status
Change from base Build 3e0276ffc94471ff55a737ab6a3041cb8050eff9: -4.3%
Covered Lines: 25033
Relevant Lines: 53623

💛 - Coveralls

@enricobattocchi enricobattocchi removed this from the 22.9 milestone Jun 4, 2024
@mhkuu mhkuu added this to the feature/fix-assessments milestone Jun 4, 2024
@mhkuu
Copy link
Contributor

mhkuu commented Jun 5, 2024

CR / ACC: 🚀

@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Jun 5, 2024
@mhkuu mhkuu merged commit 28f10ee into feature/fix-assessments Jun 5, 2024
16 of 17 checks passed
@mhkuu mhkuu deleted the disable-other-ai-buttons branch June 5, 2024 10:05
@mhkuu mhkuu changed the title Disable AI Fix buttons other than the one that is currently highlighted Disables all AI buttons other than the one currently in use Jul 16, 2024
@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants