Updates the styling of the AI buttons #21415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seo into update-styling-of-sparkle-buttons-ai-assessment-fixes
|
@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
…date-styling-of-sparkle-buttons-ai-assessment-fixes
#143 Update Toast close button.
…of github.com:Yoast/wordpress-seo into update-styling-of-sparkle-buttons-ai-assessment-fixes
#143 Styling for button.
…of github.com:Yoast/wordpress-seo into update-styling-of-sparkle-buttons-ai-assessment-fixes
Jordi-PV
added
UI change
Pull Request Test Coverage Report for Build 6541a853dd91f8833f9f1f7d3e59af686e554c1dDetails
💛 - Coveralls |
vraja-pro
reviewed
Jun 7, 2024
| </> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I would separate this component to a a file of it's own.
There was a problem hiding this comment.
You can place it back to "Needs changes" when you finish the review 😃
Pull Request Test Coverage Report for Build 167d246fb0cacdd406d6bdd2c7c7e6e8107e82f6Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3edaa99df65a8ae55c4bb980a99dcccdbf2306cdDetails
💛 - Coveralls |
vraja-pro
reviewed
Jun 7, 2024
| </> | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I think we should add a snapshot test for this one @Jordi-PV
There was a problem hiding this comment.
Update: I took care of that
|
CR & AC ✅ |
Pull Request Test Coverage Report for Build 349d2c7248ed9ca909f869f9ef94b8123fc0311bDetails
💛 - Coveralls |
mhkuu
added
the
changelog: non-user-facing
18 tasks
mhkuu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
AIFixesButtonbased on theIconButtonBaseused for the rest of the assessments functionalities.linear-gradient(). The work around is to use the border-image and background-image properties.SparklesIconcomponent instead of use the heroicon one.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes #