Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the copy for the introduction and consent modals #21431

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Jun 6, 2024

Context

  • We want to update the introduction and consent modals design and copy according to this design.

Summary

This PR can be summarized in the following changelog entry:

  • Update copy and design in the feature introduction modal.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Trigger the feature introduction modal ( remove _yoast_wpseo_introductions from your user in wp_usermeta
  • Check design is the same as the following:
    Screenshot 2024-06-06 at 17 10 25
  • Check the thumbnail is:
    thumbnail_ai_optimize

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Update copy in the introduction and consent modals

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jun 6, 2024
@vraja-pro vraja-pro requested a review from a team as a code owner June 6, 2024 14:41
@vraja-pro vraja-pro changed the base branch from trunk to feature/fix-assessments June 6, 2024 14:41
Copy link

github-actions bot commented Jun 6, 2024

@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@vraja-pro vraja-pro linked an issue Jun 6, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 8ad64796c7defa1573f74af5d98909ad551bee68

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 3710 unchanged lines in 106 files lost coverage.
  • Overall coverage decreased (-4.3%) to 48.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/ai-assessment-fixes/components/modal-content.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/builders/indexable-home-page-builder.php 1 98.0%
src/builders/indexable-term-builder.php 1 99.15%
src/context/meta-tags-context.php 1 28.29%
src/generators/breadcrumbs-generator.php 1 64.23%
src/generators/schema/webpage.php 1 90.32%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.49%
src/integrations/watchers/indexable-ancestor-watcher.php 1 98.41%
Totals Coverage Status
Change from base Build d5d0a48b1bb965a14f46d58478ae2aa521f42520: -4.3%
Covered Lines: 25063
Relevant Lines: 53654

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build fbb9e2e8f63cbc950ad17090c138f9db0757e483

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3710 unchanged lines in 106 files lost coverage.
  • Overall coverage decreased (-4.3%) to 48.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/components/content.js 0 1 0.0%
packages/js/src/ai-assessment-fixes/components/modal-content.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
admin/class-option-tabs-formatter.php 1 0.0%
src/actions/configuration/first-time-configuration-action.php 1 91.84%
src/builders/indexable-home-page-builder.php 1 98.0%
src/builders/indexable-term-builder.php 1 99.15%
src/context/meta-tags-context.php 1 28.29%
src/generators/breadcrumbs-generator.php 1 64.23%
src/generators/schema/webpage.php 1 90.32%
src/integrations/blocks/structured-data-blocks.php 1 16.0%
src/integrations/settings-integration.php 1 28.49%
src/integrations/watchers/indexable-ancestor-watcher.php 1 98.41%
Totals Coverage Status
Change from base Build d5d0a48b1bb965a14f46d58478ae2aa521f42520: -4.3%
Covered Lines: 25063
Relevant Lines: 53654

💛 - Coveralls

@mhkuu mhkuu added this to the feature/fix-assessments milestone Jun 10, 2024
…s' of github.com:Yoast/wordpress-seo into fa-zip-20240612
…ver' of github.com:Yoast/wordpress-seo into fa-zip-20240612
….com:Yoast/wordpress-seo into fa-zip-20240612
@mhkuu mhkuu changed the title 21429 update copy in the introduction and consent modals Updates the copy for the introduction and consent modals Jun 12, 2024
…seo into 21429-update-copy-in-the-introduction-and-consent-modals
Copy link
Contributor

@mhkuu mhkuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Approved mostly, apart from some small string changes. Also the video still needs to be replaced 😄

Copy link
Contributor

@mhkuu mhkuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! 😄

…s' of github.com:Yoast/wordpress-seo into 21429-update-copy-in-the-introduction-and-consent-modals
@mhkuu
Copy link
Contributor

mhkuu commented Jun 19, 2024

ACC: Looks nice! ✨

@mhkuu mhkuu merged commit dd6e866 into feature/fix-assessments Jun 19, 2024
15 checks passed
@mhkuu mhkuu deleted the 21429-update-copy-in-the-introduction-and-consent-modals branch June 19, 2024 10:04
@coveralls
Copy link

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 66ffbe7e203cf2f5f3f18009ad51181c7edb0cbf

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 119 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.1%) to 48.521%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/introductions/components/content.js 0 1 0.0%
packages/js/src/ai-assessment-fixes/components/modal-content.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/redux/reducers/advancedSettings.js 1 80.0%
packages/js/src/initializers/classic-editor-integration.js 3 0.0%
packages/js/src/redux/reducers/preferences.js 3 0.0%
packages/js/src/integrations-page/other-integrations.js 4 0.0%
packages/js/src/components/fills/MetaboxFill.js 5 0.0%
packages/js/src/containers/AdvancedSettings.js 5 0.0%
packages/js/src/helpers/fields/AdvancedFields.js 5 0.0%
packages/js/src/elementor/components/fills/ElementorFill.js 7 0.0%
packages/js/src/elementor.js 19 0.0%
packages/js/src/initializers/block-editor-integration.js 30 0.0%
Totals Coverage Status
Change from base Build 4041cc87ffe9c4b136e5e7a91f3eb4046bb2dad8: 0.1%
Covered Lines: 25082
Relevant Lines: 53575

💛 - Coveralls

@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copy in the introduction and consent modals
3 participants