-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the copy for the introduction and consent modals #21431
Updates the copy for the introduction and consent modals #21431
Conversation
@vraja-pro Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
Pull Request Test Coverage Report for Build fbb9e2e8f63cbc950ad17090c138f9db0757e483Details
💛 - Coveralls |
…s' of github.com:Yoast/wordpress-seo into fa-zip-20240612
…ver' of github.com:Yoast/wordpress-seo into fa-zip-20240612
….com:Yoast/wordpress-seo into fa-zip-20240612
packages/js/src/shared-admin/components/ai-fix-assessments-upsell.js
Outdated
Show resolved
Hide resolved
…seo into 21429-update-copy-in-the-introduction-and-consent-modals
packages/js/src/shared-admin/components/ai-fix-assessments-upsell.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Approved mostly, apart from some small string changes. Also the video still needs to be replaced 😄
…introduction-and-consent-modals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! 😄
…s' of github.com:Yoast/wordpress-seo into 21429-update-copy-in-the-introduction-and-consent-modals
ACC: Looks nice! ✨ |
Pull Request Test Coverage Report for Build 66ffbe7e203cf2f5f3f18009ad51181c7edb0cbfWarning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
_yoast_wpseo_introductions
from your user inwp_usermeta
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes Update copy in the introduction and consent modals