Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes degraded performance of content analysis #21474

Merged

Conversation

mykola
Copy link
Contributor

@mykola mykola commented Jul 12, 2024

Context

  • Fix content analysis slow down for longer texts with AI activated.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where the content analysis would perform worse when processing longer texts.

Relevant technical choices:

  • The researcher.getResearch( "morphology" ) takes some time so it was extracted to higher level from getComplexWords because when we have more than 100 sentences in the post it dramatically slow down processing.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Active Premium plugin from branch feature/fix-assessments and activate AI.
  • Create text with many sentences (500+).
  • Publish the post and refresh the page.
  • Open Premium Analysis - Analysis results.
  • Notice the time when Fix with AI buttons appears.
  • It should take less than 10 seconds (without fix - it takes about 1 minute)

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • This should not impact any other places.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #1651

@mykola mykola marked this pull request as ready for review July 12, 2024 07:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build cb038903d7db53f4d8c19481d65a0ac3993f8193

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 1651-ai-fix-content-analysis-slow-down at 57.304%

Totals Coverage Status
Change from base Build 0ddbf26850e1b61d0a4698e71534609155527ecc: 57.3%
Covered Lines: 13313
Relevant Lines: 22777

💛 - Coveralls

@mhkuu mhkuu added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 12, 2024
@mhkuu mhkuu added this to the feature/fix-assessments milestone Jul 12, 2024
Copy link
Contributor

@mhkuu mhkuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find! 🎉

@mhkuu
Copy link
Contributor

mhkuu commented Jul 12, 2024

ACC: Works! 🎉

@mhkuu mhkuu merged commit b8f7a4b into feature/fix-assessments Jul 12, 2024
17 checks passed
@mhkuu mhkuu deleted the 1651-ai-fix-content-analysis-slow-down branch July 12, 2024 14:26
@mhkuu mhkuu changed the title With AI activated, content analysis has slowed down for longer texts Fixes degraded performance of content analysis Jul 16, 2024
@mhkuu mhkuu modified the milestones: feature/fix-assessments, 23.2 Jul 16, 2024
@mhkuu mhkuu added the innovation Innovative issue. Relating to performance, memory or data-flow. label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog innovation Innovative issue. Relating to performance, memory or data-flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants