-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes showing of tooltip on AI buttons #21437
Fixes showing of tooltip on AI buttons #21437
Conversation
@Jordi-PV Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
Pull Request Test Coverage Report for Build efb72240d0cccc9e0dc9c0f53f07e0763cd74f3eDetails
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Nice work! 🥇 Just a suggestion to consider adding default props.
Pull Request Test Coverage Report for Build 4f072cf658661e4c05b86f9fe7500866107ac07dDetails
💛 - Coveralls |
ACC: checked in Chrome and Firefox, looks great! ✨ I won't merge it yet -- maybe there are some final requests from UX regarding this 😅 |
We have a 👍 from UX so merging! 🚀 |
Context
Tooltip
of the AI assessment buttons to be visible on hover over the buttons and to update the text to be: Optimize with AISummary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
We have agreed on using a uniform color for the border of the AI assessment buttons.
I've refactored the logic that makes the tooltip to be shown by adding or removing the utility classes when the mouse hovers over the buttons. This logic is different than the logic for the other assessment buttons.
We have decided to remove the time that delayed the tooltip from being shown.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
indigo-300
(#a5b4fc) color and has rounded corners.Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/plugins-automated-testing/issues/1620