Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

z_u_prior false should remove the prior #91

Merged
merged 2 commits into from
Mar 18, 2024
Merged

z_u_prior false should remove the prior #91

merged 2 commits into from
Mar 18, 2024

Conversation

justjhong
Copy link
Collaborator

Prior to this, if z_u_prior was False but z_u_prior_scale was not None (default is 0), the prior was still applied with this scale.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (ed0b8f9) to head (d773a07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files           7        7           
  Lines         869      869           
=======================================
  Hits          810      810           
  Misses         59       59           
Files Coverage Δ
src/mrvi/_module.py 94.49% <100.00%> (ø)

Copy link
Member

@martinkim0 martinkim0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @canergen thoughts?

@justjhong justjhong merged commit 6150961 into main Mar 18, 2024
9 checks passed
@justjhong justjhong deleted the jhong/zuprior branch March 18, 2024 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants