Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More nhx stuff #90

Merged
merged 2 commits into from
Nov 11, 2016
Merged

More nhx stuff #90

merged 2 commits into from
Nov 11, 2016

Conversation

caseywdunn
Copy link

A few things:

  • Added a drop.tip method

  • @nhx_tags$node now numeric

  • @nhx_tags sorted on @nhx_tags$node

Note that I added a generic for drop.tip. Noticed that you don't have generics on other methods, so not sure how you want to handle that.

Be well.

@GuangchuangYu GuangchuangYu merged commit 6b5450c into YuLab-SMU:master Nov 11, 2016
@GuangchuangYu
Copy link
Member

I detect several issues:

  1. broken existing code since no drop.tip method for phylo.
  2. a bug as you forget to update the node number in nhx_tags
  3. over-write node.label if exists
  4. forget to remove node.label if previously NULL.

All were fixed in 0b9c272.

@caseywdunn
Copy link
Author

Great catches - thanks for sorting out those issues. Looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants