Skip to content

Commit

Permalink
chore: Updating the copy in the action settings pane (appsmithorg#37260)
Browse files Browse the repository at this point in the history
## Description

Updating the copy in the action settings pane

Fixes [appsmithorg#37258](appsmithorg#37258)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11704084082>
> Commit: 723332f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11704084082&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 06 Nov 2024 15:09:44 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Enhanced testing coverage for promise handling in the Cypress
environment, improving validation of asynchronous operations.

- **Bug Fixes**
  - Updated labels in the settings tab of the query editor for clarity.
- Improved label consistency across various plugins and settings
configurations.

- **Documentation**
- Updated messaging in the `SettingsPopover` component for better user
guidance.

- **Chores**
- Standardized phrasing in multiple configuration files to enhance user
understanding across the application.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
ankitakinger authored Nov 6, 2024
1 parent 2d44267 commit cc6a66a
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
4 changes: 2 additions & 2 deletions appsmith-plugins/mongoPlugin/src/main/resources/setting.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
4 changes: 2 additions & 2 deletions appsmith-plugins/mssqlPlugin/src/main/resources/setting.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
4 changes: 2 additions & 2 deletions appsmith-plugins/mysqlPlugin/src/main/resources/setting.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
4 changes: 2 additions & 2 deletions appsmith-plugins/openAiPlugin/src/main/resources/setting.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
4 changes: 2 additions & 2 deletions appsmith-plugins/oraclePlugin/src/main/resources/setting.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
"id": 1,
"children": [
{
"label": "Run query on page load",
"label": "Run the query on page load",
"configProperty": "executeOnLoad",
"controlType": "SWITCH"
},
{
"label": "Request confirmation before running query",
"label": "Request confirmation before running this query",
"configProperty": "confirmBeforeExecute",
"controlType": "SWITCH",
"tooltipText": "Ask confirmation from the user each time before refreshing data"
Expand Down

0 comments on commit cc6a66a

Please sign in to comment.