-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updating the copy in the action settings pane #37260
Conversation
WalkthroughThe pull request introduces enhancements to the testing framework and user interface of the application. It adds comprehensive test cases for promise handling in Cypress, updates various labels in configuration files for clarity, and modifies the UI messages in the Plugin Action Settings. The changes aim to improve user understanding and consistency across the application. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (6)
app/client/cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js (1)
Line range hint
1-65
: Refactor selectors to follow Cypress best practicesThe test uses xpath and class selectors which violate our Cypress coding guidelines.
Consider these improvements:
- cy.xpath(queryLocators.querySettingsTab) + cy.get('[data-cy="query-settings-tab"]') - cy.get(".label-icon-wrapper") + cy.get('[data-cy="settings-label"]')Also, update the QueryEditor.json locators to use data-cy attributes instead of xpath selectors.
app/client/cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts (2)
Line range hint
284-284
: Remove explicit sleep call.Replace
agHelper.Sleep(1000)
with proper Cypress wait conditions. Explicit sleeps make tests flaky and unreliable.- agHelper.Sleep(1000); + agHelper.WaitUntilEleAppear(locators._toastMsg);
Line range hint
1-290
: Consider refactoring test suite for better maintainability.While the promise handling tests are comprehensive, consider these improvements:
- Extract common setup code into shared hooks or helper functions
- Group related test cases using
describe
blocks- Consider using custom commands for common promise-based operations
app/client/test/factories/MockPluginsState.ts (2)
Line range hint
4-6
: Add test coverage for the formula function.The TODO comment indicates missing tests. Please add unit tests to verify the function behavior with different input combinations.
Would you like me to help create unit tests for this function?
Line range hint
12-24
: Revise the discount and fee structure.The current implementation has two issues:
- Indentation is incorrect for the elif and else blocks
- The flat $20 fee applied after discount can negate the discount benefit, especially for smaller purchases with 10% discount tier
For example: A $100 purchase with 10% discount:
- Discounted amount: $90
- After flat fee: $110
- Result: Customer pays more than original price
Consider these alternatives:
- Apply fee before discount
- Scale fee based on purchase amount
- Waive fee for certain discount tiers
Would you like me to propose a revised implementation?
app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts (1)
Line range hint
10041-10184
: Consider reducing test data duplication.The test configuration objects are duplicated multiple times with minimal variations. Consider using a factory function to generate these configurations.
function createSettingsConfig(type: 'query' | 'api') { const isApi = type === 'api'; return { id: 1, children: [ { label: `Run the ${type} on page load`, configProperty: "executeOnLoad", controlType: "SWITCH", }, { label: `Request confirmation before running this ${type}`, configProperty: "confirmBeforeExecute", controlType: "SWITCH", tooltipText: } ] }; }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (23)
app/client/cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts
(1 hunks)app/client/cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js
(2 hunks)app/client/src/PluginActionEditor/components/PluginActionSettings/SettingsPopover.tsx
(2 hunks)app/client/src/ce/constants/messages.ts
(2 hunks)app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts
(4 hunks)app/client/src/constants/AppsmithActionConstants/formConfig/ApiSettingsConfig.ts
(1 hunks)app/client/src/constants/AppsmithActionConstants/formConfig/GoogleSheetsSettingsConfig.ts
(1 hunks)app/client/src/constants/AppsmithActionConstants/formConfig/QuerySettingsConfig.ts
(1 hunks)app/client/src/pages/Editor/SaaSEditor/__data__/FinalState.json
(7 hunks)app/client/src/pages/Editor/SaaSEditor/__data__/InitialState.json
(7 hunks)app/client/test/factories/MockPluginsState.ts
(4 hunks)app/server/appsmith-plugins/amazons3Plugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/anthropicPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/appsmithAiPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/firestorePlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/googleAiPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/mongoPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/mssqlPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/mysqlPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/openAiPlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/oraclePlugin/src/main/resources/setting.json
(1 hunks)app/server/appsmith-plugins/postgresPlugin/src/main/resources/setting.json
(1 hunks)
🔥 Files not summarized due to errors (1)
- app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts: Error: Server error: no LLM provider could handle the message
✅ Files skipped from review due to trivial changes (16)
- app/client/src/ce/constants/messages.ts
- app/client/src/constants/AppsmithActionConstants/formConfig/ApiSettingsConfig.ts
- app/client/src/constants/AppsmithActionConstants/formConfig/GoogleSheetsSettingsConfig.ts
- app/client/src/constants/AppsmithActionConstants/formConfig/QuerySettingsConfig.ts
- app/server/appsmith-plugins/amazons3Plugin/src/main/resources/setting.json
- app/server/appsmith-plugins/anthropicPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/appsmithAiPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/firestorePlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/googleAiPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/googleSheetsPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/mongoPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/mssqlPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/mysqlPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/openAiPlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/oraclePlugin/src/main/resources/setting.json
- app/server/appsmith-plugins/postgresPlugin/src/main/resources/setting.json
🧰 Additional context used
📓 Path-based instructions (2)
app/client/cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts (1)
Pattern app/client/cypress/**/**.*
: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js (1)
Pattern app/client/cypress/**/**.*
: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (13)
app/client/cypress/e2e/Regression/ClientSide/BugTests/Bug14987_spec.js (1)
34-34
: LGTM: Text updates look good
The label text changes improve clarity and maintain consistency with the rest of the application.
Also applies to: 48-48
app/client/src/PluginActionEditor/components/PluginActionSettings/SettingsPopover.tsx (2)
8-9
: LGTM! Import changes align with copy updates.
The addition of API_EDITOR_TAB_TITLES
and MORE_ON_QUERY_SETTINGS
constants is consistent with the PR's objective of updating the settings pane copy.
95-95
: LGTM! Message update improves clarity.
The switch to MORE_ON_QUERY_SETTINGS
provides more context-specific messaging compared to the generic LEARN_MORE
.
app/client/cypress/e2e/Regression/ClientSide/Binding/Promises_1_Spec.ts (1)
175-175
: LGTM: Toast message validation is clear and consistent.
The updated toast message validation aligns with the PR objective of updating copy in the settings pane.
app/client/src/pages/Editor/SaaSEditor/__data__/InitialState.json (2)
2545-2545
: LGTM: Improved clarity of page load execution labels.
The addition of "the" in "Run the query/API on page load" makes the labels more grammatically complete and clearer.
Also applies to: 2578-2578, 2611-2611, 2650-2650, 2676-2676, 2709-2709, 2742-2742
2550-2550
: LGTM: Enhanced confirmation request labels.
The addition of "this" in "Request confirmation before running this query/API" makes the labels more specific and user-friendly.
Also applies to: 2583-2583, 2616-2616, 2655-2655, 2681-2681, 2714-2714, 2747-2747
app/client/src/pages/Editor/SaaSEditor/__data__/FinalState.json (4)
2546-2551
: LGTM! Label updates improve clarity.
The changes to MongoDB plugin settings labels are more specific and clearer:
- Added "the" to make the sentence more complete
- Added "this" to make it clear which query is being referenced
2579-2584
: Consistent with MongoDB label updates.
The PostgreSQL plugin settings follow the same improved labeling pattern.
2612-2617
: API-specific label updates maintain consistency.
The REST API plugin settings appropriately use "API" instead of "query" while maintaining the same improved sentence structure.
2651-2656
: LGTM! Consistent label updates across remaining plugins.
The label updates for Firebase, Google Sheets, S3, and Redis plugins follow the same pattern, maintaining consistency across the application.
Also applies to: 2677-2682, 2710-2715, 2743-2748
app/client/test/factories/MockPluginsState.ts (1)
Line range hint 1-2
: LGTM! Simple and clean subtraction function.
app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts (2)
10041-10046
: LGTM: Query-related label updates are clear and consistent.
The updated labels for query settings are user-friendly and accurately describe the functionality.
Also applies to: 10077-10082
10113-10118
: LGTM: API-related label updates are clear and consistent.
The updated labels for API settings maintain consistency with the query labels while being specific to API context.
Also applies to: 10179-10184
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11704231777. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/styles.module.css (1)
9-26
: Consider documenting this breaking change.The attribute name change from
data-withoutPadding
todata-withoutpadding
is a breaking change that should be documented for other developers.app/client/src/pages/Editor/Explorer/Files/Submenu.tsx (3)
Line range hint
106-106
: Replace 'any' type with proper interfaceThe use of
any
type reduces type safety. Consider creating a proper interface for file operations.- {filteredFileOperations?.map((item: any, idx: number) => { + interface FileOperation { + icon?: React.ReactNode; + pluginId?: string; + shortTitle?: string; + title: string; + tooltip?: string; + } + {filteredFileOperations?.map((item: FileOperation, idx: number) => {
Line range hint
166-173
: Implement the empty handlers in handleOpenChangeThe empty handler blocks with comments suggest incomplete implementation. This could lead to inconsistent menu state management.
const handleOpenChange = (open: boolean) => { if (open) { - // handle open + setShow(true); } else { - // handle close onMenuClose(); + setShow(false); } - setShow(open); };
Line range hint
29-31
: Address TODO comments for improved type safetyMultiple TODO comments indicate pending improvements for type safety and eslint compliance. These should be addressed to maintain code quality.
Would you like me to create GitHub issues to track the implementation of proper TypeScript types and removal of eslint-disable comments?
Also applies to: 103-104
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (23)
app/client/cypress/locators/OneClickBindingLocator.ts
(1 hunks)app/client/cypress/support/Pages/DataSources.ts
(2 hunks)app/client/cypress/support/Pages/PropertyPane.ts
(1 hunks)app/client/src/IDE/Components/ToolbarSettingsPopover.tsx
(1 hunks)app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/index.tsx
(1 hunks)app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/styles.module.css
(1 hunks)app/client/src/PluginActionEditor/components/PluginActionResponse/components/BindDataButton.tsx
(1 hunks)app/client/src/PluginActionEditor/components/PluginActionResponse/components/Schema.tsx
(1 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/DropdownOption.tsx
(1 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/index.tsx
(7 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/TableOrSpreadsheetDropdown/index.tsx
(2 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/ConnectData/index.tsx
(1 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/DatasourceSpecificControls/GoogleSheetControls/SheetsDropdown/index.tsx
(1 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/WidgetSpecificControls/ColumnDropdown/index.tsx
(2 hunks)app/client/src/components/editorComponents/WidgetQueryGeneratorForm/WidgetSpecificControls/OtherFields/Field/Dropdown/useDropdown.tsx
(2 hunks)app/client/src/pages/Editor/DataSourceEditor/NewActionButton.tsx
(1 hunks)app/client/src/pages/Editor/DatasourceInfo/DatasourceViewModeSchema.tsx
(1 hunks)app/client/src/pages/Editor/DatasourceInfo/GoogleSheetSchema.tsx
(1 hunks)app/client/src/pages/Editor/Explorer/Files/Submenu.tsx
(1 hunks)app/client/src/pages/Editor/gitSync/ReconnectDatasourceModal.tsx
(1 hunks)app/client/src/pages/Editor/gitSync/components/StatusLoader.tsx
(1 hunks)app/client/src/pages/common/SearchBar/ApplicationSearchItem.tsx
(1 hunks)app/client/src/pages/common/SearchBar/WorkspaceSearchItems.tsx
(1 hunks)
✅ Files skipped from review due to trivial changes (17)
- app/client/cypress/locators/OneClickBindingLocator.ts
- app/client/cypress/support/Pages/DataSources.ts
- app/client/cypress/support/Pages/PropertyPane.ts
- app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/index.tsx
- app/client/src/PluginActionEditor/components/PluginActionResponse/components/Schema.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/DropdownOption.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/DatasourceDropdown/index.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/CommonControls/TableOrSpreadsheetDropdown/index.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/DatasourceSpecificControls/GoogleSheetControls/SheetsDropdown/index.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/WidgetSpecificControls/ColumnDropdown/index.tsx
- app/client/src/components/editorComponents/WidgetQueryGeneratorForm/WidgetSpecificControls/OtherFields/Field/Dropdown/useDropdown.tsx
- app/client/src/pages/Editor/DataSourceEditor/NewActionButton.tsx
- app/client/src/pages/Editor/DatasourceInfo/DatasourceViewModeSchema.tsx
- app/client/src/pages/Editor/DatasourceInfo/GoogleSheetSchema.tsx
- app/client/src/pages/Editor/gitSync/ReconnectDatasourceModal.tsx
- app/client/src/pages/Editor/gitSync/components/StatusLoader.tsx
- app/client/src/pages/common/SearchBar/WorkspaceSearchItems.tsx
🔇 Additional comments (7)
app/client/src/components/editorComponents/WidgetQueryGeneratorForm/ConnectData/index.tsx (1)
12-12
: LGTM: Test ID attribute follows React conventions.
The change from data-testId
to data-testid
aligns with React testing best practices.
app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/styles.module.css (1)
9-11
: LGTM! Verify components using these selectors.
The change to lowercase data attributes follows HTML5 conventions. However, we should ensure all components using these selectors are updated.
Also applies to: 14-16, 19-21, 24-26
✅ Verification successful
The previous command failed because the file type wasn't recognized. Let's try a broader search and also verify the presence of JSX/TSX files to ensure we're searching in the right places.
From the search results, I can see that the data-withoutpadding
attribute is used in both the CSS file and its corresponding component file:
- CSS:
app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/styles.module.css
- Component:
app/client/src/PluginActionEditor/components/PluginActionForm/components/ActionForm/Section/index.tsx
The component is already using the lowercase version data-withoutpadding
, so this CSS change aligns with the existing component implementation. No other components are using this attribute.
CSS change is safe to proceed
The attribute is consistently used in lowercase form across the codebase, and this CSS change brings the selectors in line with the actual component usage.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining camelCase usage of the attribute
rg -i "data-withoutPadding" --type=tsx --type=jsx
Length of output: 77
Script:
#!/bin/bash
# Search for any remaining camelCase usage of the attribute in all files
rg -i "data-withoutpadding|data-withoutPadding"
# Also search for JSX/TSX files to ensure we have the right file types
fd "\.(tsx|jsx)$"
Length of output: 141785
app/client/src/IDE/Components/ToolbarSettingsPopover.tsx (2)
Line range hint 1-61
: Verify if copy updates are missing from this PR.
The PR objective mentions updating copy in the settings pane, but this file only contains a test attribute change. Please verify if additional changes are needed to fulfill the PR objective.
Let's check for any pending copy changes:
46-46
: LGTM: Standardizing data-testid attribute.
The change aligns with HTML attribute naming conventions.
Let's verify the consistency of this change across the codebase:
app/client/src/pages/common/SearchBar/ApplicationSearchItem.tsx (1)
39-39
: LGTM: Test attribute naming follows React conventions.
The change from data-testId
to data-testid
aligns with React's HTML data attribute naming convention.
app/client/src/pages/Editor/Explorer/Files/Submenu.tsx (1)
97-97
: LGTM: Correct data-testid casing
The attribute change follows React Testing Library conventions.
app/client/src/PluginActionEditor/components/PluginActionResponse/components/BindDataButton.tsx (1)
388-388
: LGTM: Test identifier standardization
The change from data-testId
to data-testid
aligns with the HTML attribute case-sensitivity standards and maintains consistency across the codebase.
Deploy-Preview-URL: https://ce-37260.dp.appsmith.com |
## Description Updating the copy in the action settings pane Fixes [appsmithorg#37258](appsmithorg#37258) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11704084082> > Commit: 723332f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11704084082&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 06 Nov 2024 15:09:44 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced testing coverage for promise handling in the Cypress environment, improving validation of asynchronous operations. - **Bug Fixes** - Updated labels in the settings tab of the query editor for clarity. - Improved label consistency across various plugins and settings configurations. - **Documentation** - Updated messaging in the `SettingsPopover` component for better user guidance. - **Chores** - Standardized phrasing in multiple configuration files to enhance user understanding across the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Description Updating the copy in the action settings pane Fixes [appsmithorg#37258](appsmithorg#37258) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11704084082> > Commit: 723332f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11704084082&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 06 Nov 2024 15:09:44 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced testing coverage for promise handling in the Cypress environment, improving validation of asynchronous operations. - **Bug Fixes** - Updated labels in the settings tab of the query editor for clarity. - Improved label consistency across various plugins and settings configurations. - **Documentation** - Updated messaging in the `SettingsPopover` component for better user guidance. - **Chores** - Standardized phrasing in multiple configuration files to enhance user understanding across the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Updating the copy in the action settings pane
Fixes #37258
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11704084082
Commit: 723332f
Cypress dashboard.
Tags:
@tag.All
Spec:
Wed, 06 Nov 2024 15:09:44 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
SettingsPopover
component for better user guidance.Chores