-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Codecov Report
@@ Coverage Diff @@
## feature/i18n #828 +/- ##
================================================
- Coverage 84.34% 84.22% -0.12%
================================================
Files 111 111
Lines 3857 3880 +23
================================================
+ Hits 3253 3268 +15
- Misses 432 436 +4
- Partials 172 176 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions:
- I remember emojis were not working on windows, is this case fine?
- More important than registering the default English, is the current version statically using the English language. We are not selecting the language based on the config yet right?
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far, it's a good refactoring and improvement in init, I will wait for the changes in the tests to finalize the review.
- Could you put a gif about the init process in the description, please?
|
We are not selecting the language based on the config, we will do that in the next PR! |
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
I am still missing the test comment reply |
/merge qa |
👌 Merged branch feature/select_lang into qa |
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
metricSender, | ||
ritConfigMock, | ||
) | ||
|
||
initPrompt.PersistentFlags().Bool("stdin", false, "input by stdin") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should support flags for the init command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, but in order not to escape further from the context of this PR I prefer to do it in a separate task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice, just a comment
"github.com/ZupIT/ritchie-cli/pkg/rtutorial" | ||
"github.com/ZupIT/ritchie-cli/pkg/stream" | ||
sMocks "github.com/ZupIT/ritchie-cli/pkg/stream/mocks" | ||
) | ||
|
||
func Test_initCmd_runAnyEntry(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename to CameCase?
* Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
* Create config file to ritchie (ZupIT#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (ZupIT#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (ZupIT#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
* Support flags for the git update repo command. * Support flags for the rit update repo command. * Internationalization Ritchie-cli (#847) * Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Adding flags, delete confirmation and new tests to delete repo (#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Feature/add formula rit list formulas (#913) * added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Removal of the Run FuncEF method that I had created. Standardize methods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Remove comment Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Adjust in return to perform only an update repo on runCmd. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Variable renamed with a more complete name. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Linter Fix, gofmt. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Fix version update prompt, fix array lenght in update flags Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change error msg Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change return 'err' to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * add 'externalRepos', with only remote repositorys Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * First tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * gofmt file Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * small changes and working tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * All Tests Working, Need Refactor Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Working Tests with assert Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Last test, invalid repo Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change output error to fmt.Errorf Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * remove variable flagAll Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * declaration of success message in just one place Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * addition of the help message addition of the help message Co-authored-by: Kadu Artur Prussek <kadu.artur@gmail.com> Co-authored-by: fernandobelettizup <60020008+fernandobelettizup@users.noreply.github.com>
Description
Improve
rit init
command and add the default language to English.How to verify it
It's a small part of the #775 issue, a separate pull request was created to facilitate code review