Improve rit init command #828

kaduartur · 2021-01-13T18:08:24Z

Description

Improve rit initcommand and add the default language to English.

How to verify it

It's a small part of the #775 issue, a separate pull request was created to facilitate code review

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

codecov-io · 2021-01-13T18:42:00Z

Codecov Report

Merging #828 (50abb72) into feature/i18n (7b55c06) will decrease coverage by 0.11%.
The diff coverage is 96.92%.

@@               Coverage Diff                @@
##           feature/i18n     #828      +/-   ##
================================================
- Coverage         84.34%   84.22%   -0.12%     
================================================
  Files               111      111              
  Lines              3857     3880      +23     
================================================
+ Hits               3253     3268      +15     
- Misses              432      436       +4     
- Partials            172      176       +4

Impacted Files	Coverage Δ
pkg/cmd/init.go	`95.55% <96.49%> (-4.45%)`	⬇️
pkg/cmd/upgrade.go	`100.00% <100.00%> (ø)`
pkg/commands/builder.go	`90.35% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b55c06...50abb72. Read the comment docs.

pkg/cmd/init.go

henriquemoraeszup

A couple of questions:

I remember emojis were not working on windows, is this case fine?
More important than registering the default English, is the current version statically using the English language. We are not selecting the language based on the config yet right?

pkg/cmd/upgrade_test.go

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

pkg/cmd/init.go

brunasilvazup

So far, it's a good refactoring and improvement in init, I will wait for the changes in the tests to finalize the review.

Could you put a gif about the init process in the description, please?

henriquemoraeszup · 2021-01-14T15:45:48Z

A couple of questions:

...

More important than registering the default English, is the current version statically using the English language. We are not selecting the language based on the config yet right?

kaduartur · 2021-01-14T18:18:38Z

A couple of questions:

I remember emojis were not working on windows, is this case fine?

More important than registering the default English is the current version statically using the English language. We are not selecting the language based on the config yet, right?

We are not selecting the language based on the config, we will do that in the next PR!

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

henriquemoraeszup · 2021-01-14T20:29:33Z

I am still missing the test comment reply

kaduartur · 2021-01-18T13:20:59Z

/merge qa

ritchie-bot · 2021-01-18T13:21:04Z

👌 Merged branch feature/select_lang into qa

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

internal/mocks/mocks.go

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

pkg/cmd/init_test.go

henriquemoraeszup · 2021-01-19T19:35:09Z

pkg/cmd/init_test.go

 				metricSender,
+				ritConfigMock,
 			)

 			initPrompt.PersistentFlags().Bool("stdin", false, "input by stdin")


We should support flags for the init command

I think this is good, but in order not to escape further from the context of this PR I prefer to do it in a separate task

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

henriquemoraeszup

Niiice, just a comment

henriquemoraeszup · 2021-01-20T13:47:55Z

pkg/cmd/init_test.go

 	"github.com/ZupIT/ritchie-cli/pkg/rtutorial"
-	"github.com/ZupIT/ritchie-cli/pkg/stream"
-	sMocks "github.com/ZupIT/ritchie-cli/pkg/stream/mocks"
 )

 func Test_initCmd_runAnyEntry(t *testing.T) {


Can you rename to CameCase?

* Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

* Create config file to ritchie (ZupIT#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (ZupIT#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (ZupIT#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

* Support flags for the git update repo command. * Support flags for the rit update repo command. * Internationalization Ritchie-cli (#847) * Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Adding flags, delete confirmation and new tests to delete repo (#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Feature/add formula rit list formulas (#913) * added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Removal of the Run FuncEF method that I had created. Standardize methods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Remove comment Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Adjust in return to perform only an update repo on runCmd. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Variable renamed with a more complete name. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Linter Fix, gofmt. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Fix version update prompt, fix array lenght in update flags Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change error msg Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change return 'err' to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * add 'externalRepos', with only remote repositorys Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * First tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * gofmt file Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * small changes and working tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * All Tests Working, Need Refactor Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Working Tests with assert Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Last test, invalid repo Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change output error to fmt.Errorf Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * remove variable flagAll Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * declaration of success message in just one place Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * addition of the help message addition of the help message Co-authored-by: Kadu Artur Prussek <kadu.artur@gmail.com> Co-authored-by: fernandobelettizup <60020008+fernandobelettizup@users.noreply.github.com>

Improve rit init command

645b582

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur added 🔨 improvement Improvement in features ✔️ ready-for-review ready for review labels Jan 13, 2021

kaduartur self-assigned this Jan 13, 2021

kaduartur requested review from brunasilvazup, henriquemoraeszup, lucasdittrichzup and rodrigomedeirosf as code owners January 13, 2021 18:08

Fix lint

abfb82c

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

brunasilvazup reviewed Jan 13, 2021

View reviewed changes

pkg/cmd/init.go Outdated Show resolved Hide resolved

brunasilvazup reviewed Jan 13, 2021

View reviewed changes

pkg/cmd/init.go Show resolved Hide resolved

henriquemoraeszup reviewed Jan 13, 2021

View reviewed changes

pkg/cmd/upgrade_test.go Show resolved Hide resolved

Fix functional tests

94c4d74

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

brunasilvazup reviewed Jan 14, 2021

View reviewed changes

pkg/cmd/init.go Outdated Show resolved Hide resolved

brunasilvazup reviewed Jan 14, 2021

View reviewed changes

kaduartur added 2 commits January 14, 2021 16:29

Improve rit init tests

50d8624

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

Fix lint

50abb72

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur added 2 commits January 19, 2021 11:10

Fix init for Windows

4159157

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

Remove comment

d42690d

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

henriquemoraeszup reviewed Jan 19, 2021

View reviewed changes

internal/mocks/mocks.go Outdated Show resolved Hide resolved

kaduartur added 2 commits January 19, 2021 15:17

Fix init message

324573c

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

Fix lint

94364b0

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

henriquemoraeszup reviewed Jan 19, 2021

View reviewed changes

pkg/cmd/init_test.go Outdated Show resolved Hide resolved

henriquemoraeszup reviewed Jan 19, 2021

View reviewed changes

brunasilvazup requested review from henriquemoraeszup and brunasilvazup January 19, 2021 19:55

Fix tests

952b748

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

brunasilvazup approved these changes Jan 19, 2021

View reviewed changes

kaduartur merged commit bd83406 into ZupIT:feature/i18n Jan 20, 2021

kaduartur deleted the feature/select_lang branch January 20, 2021 13:47

henriquemoraeszup approved these changes Jan 20, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve rit init command #828

Improve rit init command #828

kaduartur commented Jan 13, 2021

codecov-io commented Jan 13, 2021 •

edited

Loading

henriquemoraeszup left a comment •

edited

Loading

brunasilvazup left a comment

henriquemoraeszup commented Jan 14, 2021

kaduartur commented Jan 14, 2021

henriquemoraeszup commented Jan 14, 2021

kaduartur commented Jan 18, 2021

ritchie-bot bot commented Jan 18, 2021

henriquemoraeszup Jan 19, 2021

kaduartur Jan 19, 2021

henriquemoraeszup left a comment

henriquemoraeszup Jan 20, 2021

Improve rit init command #828

Improve rit init command #828

Conversation

kaduartur commented Jan 13, 2021

Description

How to verify it

codecov-io commented Jan 13, 2021 • edited Loading

Codecov Report

henriquemoraeszup left a comment • edited Loading

Choose a reason for hiding this comment

brunasilvazup left a comment

Choose a reason for hiding this comment

henriquemoraeszup commented Jan 14, 2021

kaduartur commented Jan 14, 2021

henriquemoraeszup commented Jan 14, 2021

kaduartur commented Jan 18, 2021

ritchie-bot bot commented Jan 18, 2021

henriquemoraeszup Jan 19, 2021

Choose a reason for hiding this comment

kaduartur Jan 19, 2021

Choose a reason for hiding this comment

henriquemoraeszup left a comment

Choose a reason for hiding this comment

henriquemoraeszup Jan 20, 2021

Choose a reason for hiding this comment

codecov-io commented Jan 13, 2021 •

edited

Loading

henriquemoraeszup left a comment •

edited

Loading