Internationalization Ritchie-cli #847

kaduartur · 2021-02-03T15:12:11Z

Description

This pull request implements the internationalization of Ritchie-cli:

We created a new package called i18n which contains the translation solver by ID and a file called translations.go which is automatically generated by the make generate-translation command, it is worth remembering that when updating the translation files in resource/i18n we should always run this command.
We centralize the Richie-cli configurations in one place, the file responsible for writing and reading these configs is at /internal/pkg/config/config.go. The new config file is created at ˜/.rit/configs.toml.
Improved the user experience in the rit init command, already using the Ritchie translation part.
Here is a demonstration of the git init command:

How to verify it

When executing any Ritchie command it should behave like the latest versions, only the rit init command that has had visual modifications.

Changelog

Internationalization Ritchie-cli

* Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

* Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

* Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

henriquemoraeszup

Can you update the readme on how to create translations, which files to edit, which order to add a new term (is it alphabetic? by package?)

stale · 2021-04-07T00:12:47Z

This PR has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this PR and helping make Ritchie a better product!

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

codecov-commenter · 2021-04-26T18:29:47Z

Codecov Report

Merging #847 (868d5c7) into master (72d6dac) will increase coverage by 0.03%.
The diff coverage is 98.79%.

❗ Current head 868d5c7 differs from pull request most recent head a0310a4. Consider uploading reports for the commit a0310a4 to get more accurate results

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   85.72%   85.75%   +0.03%     
==========================================
  Files         117      117              
  Lines        4147     4171      +24     
==========================================
+ Hits         3555     3577      +22     
- Misses        403      404       +1     
- Partials      189      190       +1

Impacted Files	Coverage Δ
pkg/cmd/init.go	`98.89% <98.66%> (-1.11%)`	⬇️
pkg/cmd/upgrade.go	`100.00% <100.00%> (ø)`
pkg/commands/builder.go	`90.54% <100.00%> (+0.04%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d6dac...a0310a4. Read the comment docs.

internal/pkg/config/config_test.go

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur · 2021-04-28T18:40:18Z

/merge qa

ritchie-bot · 2021-04-28T18:40:22Z

👌 Merged branch feature/i18n into qa

brunasilvazup

🥇

* Create config file to ritchie (ZupIT#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (ZupIT#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (ZupIT#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

* Support flags for the git update repo command. * Support flags for the rit update repo command. * Internationalization Ritchie-cli (#847) * Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Adding flags, delete confirmation and new tests to delete repo (#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Feature/add formula rit list formulas (#913) * added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Removal of the Run FuncEF method that I had created. Standardize methods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Remove comment Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Adjust in return to perform only an update repo on runCmd. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Variable renamed with a more complete name. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Linter Fix, gofmt. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Fix version update prompt, fix array lenght in update flags Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change error msg Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change return 'err' to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * add 'externalRepos', with only remote repositorys Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * First tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * gofmt file Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * small changes and working tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * All Tests Working, Need Refactor Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Working Tests with assert Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Last test, invalid repo Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change output error to fmt.Errorf Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * remove variable flagAll Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * declaration of success message in just one place Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * addition of the help message addition of the help message Co-authored-by: Kadu Artur Prussek <kadu.artur@gmail.com> Co-authored-by: fernandobelettizup <60020008+fernandobelettizup@users.noreply.github.com>

kaduartur added 4 commits January 12, 2021 14:38

Merge branch 'master' into feature/i18n

95da2c0

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur added ✨ feature Suggest a new feature or enhancement to the Ritchie project ✔️ ready-for-review ready for review labels Feb 3, 2021

kaduartur self-assigned this Feb 3, 2021

kaduartur requested review from brunasilvazup, henriquemoraeszup, lucasdittrichzup and rodrigomedeirosf as code owners February 3, 2021 15:12

kaduartur linked an issue Feb 3, 2021 that may be closed by this pull request

Add lib to support internationalization #775

Closed

1 task

brunasilvazup added the 🆘 help wanted Extra attention is needed label Feb 4, 2021

brunasilvazup previously approved these changes Feb 4, 2021

View reviewed changes

henriquemoraeszup suggested changes Feb 5, 2021

View reviewed changes

brunasilvazup added waiting reply Waiting for an answer to a comment and removed ✔️ ready-for-review ready for review labels Feb 5, 2021

stale bot added the stale label Apr 7, 2021

henriquemoraeszup removed the stale label Apr 8, 2021

Merge branch 'master' into feature/i18nOC

34c61f5

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur dismissed brunasilvazup’s stale review via 34c61f5 April 26, 2021 18:23

kaduartur requested a review from fernandobelettizup as a code owner April 26, 2021 18:23

Create translation guide

868d5c7

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

Update DEVELOPER_GUIDE.md

a0310a4

brunasilvazup added ✔️ ready-for-review ready for review and removed waiting reply Waiting for an answer to a comment labels Apr 27, 2021

brunasilvazup reviewed Apr 27, 2021

View reviewed changes

internal/pkg/config/config_test.go Outdated Show resolved Hide resolved

brunasilvazup previously approved these changes Apr 27, 2021

View reviewed changes

Fix config_test.go

3f625f7

Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>

kaduartur dismissed brunasilvazup’s stale review via 3f625f7 April 27, 2021 19:32

kaduartur removed the 🆘 help wanted Extra attention is needed label Apr 28, 2021

brunasilvazup approved these changes Apr 29, 2021

View reviewed changes

henriquemoraeszup approved these changes Apr 29, 2021

View reviewed changes

kaduartur merged commit 0a7e37b into master Apr 29, 2021

kaduartur deleted the feature/i18n branch April 29, 2021 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internationalization Ritchie-cli #847

Internationalization Ritchie-cli #847

kaduartur commented Feb 3, 2021

henriquemoraeszup left a comment

stale bot commented Apr 7, 2021

codecov-commenter commented Apr 26, 2021 •

edited

Loading

kaduartur commented Apr 28, 2021

ritchie-bot bot commented Apr 28, 2021

brunasilvazup left a comment

Internationalization Ritchie-cli #847

Internationalization Ritchie-cli #847

Conversation

kaduartur commented Feb 3, 2021

Description

How to verify it

Changelog

henriquemoraeszup left a comment

Choose a reason for hiding this comment

stale bot commented Apr 7, 2021

codecov-commenter commented Apr 26, 2021 • edited Loading

Codecov Report

kaduartur commented Apr 28, 2021

ritchie-bot bot commented Apr 28, 2021

brunasilvazup left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 26, 2021 •

edited

Loading