-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
* Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
* Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
* Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the readme on how to create translations, which files to edit, which order to add a new term (is it alphabetic? by package?)
This PR has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 7 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this PR and helping make Ritchie a better product! |
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 85.72% 85.75% +0.03%
==========================================
Files 117 117
Lines 4147 4171 +24
==========================================
+ Hits 3555 3577 +22
- Misses 403 404 +1
- Partials 189 190 +1
Continue to review full report at Codecov.
|
Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
/merge qa |
👌 Merged branch feature/i18n into qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
* Create config file to ritchie (ZupIT#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (ZupIT#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (ZupIT#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com>
* Support flags for the git update repo command. * Support flags for the rit update repo command. * Internationalization Ritchie-cli (#847) * Create config file to ritchie (#825) * Create translation Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create config file Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove unused dependency Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init command (#828) * Improve rit init command Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix functional tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Improve rit init tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init for Windows Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Remove comment Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix init message Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix tests Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation for init command (#834) * Add translation for init cmd Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix makefile Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix vendor Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix lint Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Fix read config Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Create translation guide Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Update DEVELOPER_GUIDE.md * Fix config_test.go Signed-off-by: Kadu Artur Prussek <kadu.artur@gmail.com> * Adding flags, delete confirmation and new tests to delete repo (#908) * added support flags, added delete confirmation and changed tests for rit delete repo Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fix lint Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed "Delete repo STDIN" from stdin_integration_test Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removal, added local name for flag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing unit tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added nameFlag to error message Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added flag to check if repo must be deleted Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * using missingFlagText method Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * removed existingRepoIsDeleted when value is false from tests struct Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin removed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting stdin scenarios Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed sdtin_feature.json repo url, previous url stopped working Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * chaging test repo tag Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * method renamed runFormula -> runCmd Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Feature/add formula rit list formulas (#913) * added list formulas command, changes to tree and builder Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added input flags support Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * creating test file Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test cases Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed check if repo exists logic to avoid for loop Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * tree checker_test fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * additional lint fixes (misspelling + preallocation) Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * misspelling fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint prealloc fix Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * minor suggestion fixes Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added check for empty tree and case tests, changed logic for repo not found Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * reverting error logic on default tree, errors now in list_formula.go Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint: misspelling Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added list formula to api.commands Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified a var declaration Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added missingFlagText, changes to constructor and flag description Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added asserts for printed output Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * ignoring print errors on ALL flag, added warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * added test case to check warning Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * changed method name, list repos logic, replacer logic, empty repo warning and tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * simplified printformulas to return warnings, changed tests Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * lint fix -> no error returning from printFormulas, just warnings Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * fixing merge buid conflict Signed-off-by: fernandobelettizup <fernando.beletti@zup.com.br> * Removal of the Run FuncEF method that I had created. Standardize methods according to other commands. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Remove comment Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Adjust in return to perform only an update repo on runCmd. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Variable renamed with a more complete name. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Linter Fix, gofmt. Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Fix version update prompt, fix array lenght in update flags Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change error msg Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change return 'err' to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * add 'externalRepos', with only remote repositorys Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * change err to nil Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * First tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * gofmt file Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * small changes and working tests Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * All Tests Working, Need Refactor Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Working Tests with assert Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Last test, invalid repo Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * Change output error to fmt.Errorf Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * remove variable flagAll Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * declaration of success message in just one place Signed-off-by: maurineimirandazup <maurinei.miranda@zup.com.br> * addition of the help message addition of the help message Co-authored-by: Kadu Artur Prussek <kadu.artur@gmail.com> Co-authored-by: fernandobelettizup <60020008+fernandobelettizup@users.noreply.github.com>
Description
This pull request implements the internationalization of Ritchie-cli:
We created a new package called i18n which contains the translation solver by ID and a file called
translations.go
which is automatically generated by themake generate-translation
command, it is worth remembering that when updating the translation files inresource/i18n
we should always run this command.We centralize the Richie-cli configurations in one place, the file responsible for writing and reading these configs is at
/internal/pkg/config/config.go
. The new config file is created at˜/.rit/configs.toml
.Improved the user experience in the
rit init
command, already using the Ritchie translation part.Here is a demonstration of the git init command:
How to verify it
When executing any Ritchie command it should behave like the latest versions, only the
rit init
command that has had visual modifications.Changelog
Internationalization Ritchie-cli