Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo skip of cargo +nightly fmt for Mac ARM. #174

Closed
jsirois opened this issue Nov 23, 2023 · 1 comment · Fixed by #178
Closed

Undo skip of cargo +nightly fmt for Mac ARM. #174

jsirois opened this issue Nov 23, 2023 · 1 comment · Fixed by #178
Assignees
@jsirois
Labels
cleanup Paying down technical debt / making it easier to develop

Comments

@jsirois
Copy link
Collaborator

jsirois commented Nov 23, 2023

The skip works around this Mac ARM specific issue for rustfmt nightly: rust-lang/rustfmt#5964
@jsirois jsirois added the cleanup Paying down technical debt / making it easier to develop label Nov 23, 2023
@jsirois
Copy link
Collaborator Author

jsirois commented Nov 23, 2023

Actually, it looks to be a generic ARM issue; so undo CircleCI skip for Linux ARM as well.

This was referenced Nov 23, 2023
Merged
Closed
@jsirois jsirois self-assigned this Dec 9, 2023
@jsirois jsirois added the in progress Indicates the assignee is actively working on the item. label Dec 9, 2023
jsirois added a commit to jsirois/jump that referenced this issue Dec 9, 2023
@jsirois
Undo aarch64 rustfmt skips.
5cd7986 
These skips were added in a-scie#173 to work around this issue:
  rust-lang/rustfmt#5964

It has been resolved; so formatting should now work on all
architectures.

Fixes a-scie#174
@jsirois jsirois mentioned this issue Dec 9, 2023
Merged
jsirois added a commit that referenced this issue Dec 10, 2023
@jsirois
Undo aarch64 rustfmt skips. (#178)
238b487 
These skips were added in #173 to work around this issue:
  rust-lang/rustfmt#5964

It has been resolved; so formatting should now work on all
architectures.

Fixes #174
@jsirois jsirois removed the in progress Indicates the assignee is actively working on the item. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
cleanup Paying down technical debt / making it easier to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Undo aarch64 rustfmt skips. jsirois/jump
1 participant
@jsirois