-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix our xz2 crate configuration to enable static linking. #173
Conversation
Previously liblzma was dynamically linked (to a homebrew version). Fixes a-scie#172
The linking is now:
|
The fix is good, but I'm in a weird state where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that the Cargo.toml
change is the only real change, and the code changes are "just" reformatting?
Are you aware that rustup supports pinning to particular nightlies via nightly-$date
? For instance, rustup toolchain add nightly-2023-11-20
. https://rust-lang.github.io/rustup/concepts/toolchains.html#toolchain-specification This might allow getting stable formatting that only changes when explicitly desired, or at least pinning to a version that doesn't have the inconsistencies.
Yeah, but I've never had to do this until now - totally unclear why. Even having to use nightly at all is horrible. I'm not sure what is up with the glacial pace of the promotion of rustfmt nightly features compared to rust otherwise. |
This is a very crappy situation. Wanting to use stable, and encoding that in rust-toolchain so all devs get things working, but then using nightly for rustfmt. Afaict I'm forced to add docs or an outer script or both to make sure fmt just works as well. Having to use a magic nightly pinned version is going to skate right by a new dev. In fact, it will mess me up too I'm sure when I forget a month from now. |
I'm going to sink some time into this rustfmt reproducibility situation before landing. |
Alright, much headbanging but I should have looked at issues: rust-lang/rustfmt#5964 Still not sure what to do, but this appears to be a ~temporary problem. |
Alright - the rustfmt noise is isolated to some ~commented out CI steps and tracked in #174. I'll merge once green since those CI fixes are minimal despite being orthogonal. |
These skips were added in a-scie#173 to work around this issue: rust-lang/rustfmt#5964 It has been resolved; so formatting should now work on all architectures. Fixes a-scie#174
These skips were added in #173 to work around this issue: rust-lang/rustfmt#5964 It has been resolved; so formatting should now work on all architectures. Fixes #174
Previously liblzma was dynamically linked (to a homebrew version).
Fixes #172