Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement or ignore endOfStream in AblyEventStreamHandler. MainThreadEventSink #9

Open
tiholic opened this issue May 6, 2020 · 2 comments
Open

implement or ignore endOfStream in AblyEventStreamHandler. MainThreadEventSink #9

tiholic opened this issue May 6, 2020 · 2 comments
Labels
enhancement New feature or improved functionality.

Comments

@tiholic
Copy link
Contributor

tiholic commented May 6, 2020 •
edited by sync-by-unito bot
Loading

Either implement or ignore end of stream method based on usage once the package is in good shape.

#6 (comment)

┆Issue is synchronized with this Jira Task by Unito
@tiholic tiholic mentioned this issue May 6, 2020
Merged
@tiholic tiholic added the enhancement New feature or improved functionality. label Aug 18, 2020
QuintinWillison added a commit that referenced this issue Mar 19, 2021
@QuintinWillison
Add pub get step.
6cfcf59 
Hoping to solve this error in workflow environment:

Unhandled exception:
Invalid argument (uri): Unknown package: Instance of '_SimpleUri'
#0      _resolveUri.<anonymous closure> (package:dartdoc/src/generator/resource_loader.dart:34:9)
#1      _RootZone.runUnary (dart:async/zone.dart:1612:54)
#2      _FutureListener.handleValue (dart:async/future_impl.dart:152:18)
#3      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:704:45)
#4      Future._propagateToListeners (dart:async/future_impl.dart:733:32)
#5      Future._completeWithValue (dart:async/future_impl.dart:539:5)
#6      Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:577:7)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#8      _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:120:13)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:185:5)
Error: Process completed with exit code 255.
@ikbalkaya
Copy link
Contributor

I am having difficulty understanding what this issue trying to address. Looking at MainThreadEventSink's endOfStream and it's there and ignored. Task says 'implement or ignore' @QuintinWillison Do you think this is still relevant 🤔

@QuintinWillison
Copy link
Contributor

@ikbalkaya At the time this issue was raised we were exploring the requirements of stream implementations, and so this concern came up as something we should investigate. Given how long this issue has been open, if you're happy that there's no work to be done here, then please feel free to close it.

@sync-by-unito sync-by-unito bot mentioned this issue Oct 26, 2022
Open
@sync-by-unito sync-by-unito bot removed the enhancement New feature or improved functionality. label Feb 6, 2023
@ttypic ttypic added the enhancement New feature or improved functionality. label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ikbalkaya @QuintinWillison @tiholic @ttypic