Can't import from 'ably/react' on v2 branch #1622
Assignees
Labels
bug
Something isn't working. It's clear that this does need to be fixed.
Comments
VeskeR
added
the
bug
|
This is because they haven't properly implemented or exported their types correctly. |
VeskeR
added a commit
that referenced
this issue
Feb 19, 2024
Also removes "exports" property from package.react.json in react-hooks folder that is copied to `react` build folder. This file now only has `"main": "./cjs/index.js"`, which, for not obvious reason to me, needs to be present in order for `npx attw` check to not show "Resolution failed" error for node10 for "ably/react" path. Resolves #1622
VeskeR
added a commit
that referenced
this issue
Feb 21, 2024
Similar to 9976a84, adds a test for importing from `ably/react` from ably-js NPM package. This test will catch NPM package errors like in #1622. Followed playwright for Components guide [1] to setup this. [1] https://playwright.dev/docs/test-components
VeskeR
added a commit
that referenced
this issue
Feb 21, 2024
Similar to 9976a84, adds a test for importing from `ably/react` from ably-js NPM package. This test will catch NPM package errors like in #1622. Followed playwright for Components guide [1] to setup this. [1] https://playwright.dev/docs/test-components
VeskeR
added a commit
that referenced
this issue
Feb 21, 2024
Similar to 9976a84, adds a test for importing from `ably/react` from ably-js NPM package. This test will catch NPM package errors like in #1622. Followed playwright for Components guide [1] to setup this. [1] https://playwright.dev/docs/test-components
|
Fixed in #1625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
package.jsonexportsfield does not define export for 'ably/react', so we get an error when trying to import from this path in real application:┆Issue is synchronized with this Jira Bug by Unito
The text was updated successfully, but these errors were encountered: