[ECO-4114] Fix missing ably/react export from ably package on v2 branch
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
VeskeR
changed the base branch from
integration/v2
to
1619/fix-ably-import-in-react-hooks
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
jamienewcomb
changed the title
ably/react export from ably package on v2 branchably/react export from ably package on v2 branch
Also removes "exports" property from package.react.json in react-hooks folder that is copied to `react` build folder. This file now only has `"main": "./cjs/index.js"`, which, for not obvious reason to me, needs to be present in order for `npx attw` check to not show "Resolution failed" error for node10 for "ably/react" path. Resolves #1622
VeskeR
force-pushed
the
1622/fix-ably-react-import
branch
from
30e755f to
72c131e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
VeskeR
force-pushed
the
1622/fix-ably-react-import
branch
from
01d676e to
241ef0e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
…ge/browser/template` Downgrade to 1.39.0 to match installed `@playwright/test` version. Otherwise playwright will throw errors on test run due to version mismatch.
Similar to 9976a84, adds a test for importing from `ably/react` from ably-js NPM package. This test will catch NPM package errors like in #1622. Followed playwright for Components guide [1] to setup this. [1] https://playwright.dev/docs/test-components
Had to downgrade version for explicit dev dependency for `esbuild` to match version used by `@playwright/experimental-ct-react` (0.18.20). It was causing 'Error: Expected "0.19.5" but got "0.18.20"' errors in CI, see job log [1]. [1] https://github.com/ably/ably-js/actions/runs/7984893618/job/21802628829
VeskeR
force-pushed
the
1622/fix-ably-react-import
branch
from
4be7291 to
86ee859
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
`npm run test-ct` was failing in CI (see job log [1]) with reference to a npm bug [2] and suggested to delete package-lock.json and do `npm install` to rebuild it. This commit has the result of it. Also this commit changes `lockfileVersion` in package-lock.json to 3, which is backwards compatible to npm v7 (bundled with node starting from version 15). We're using node16 in CI for package tests, so it's fine. [1] https://github.com/ably/ably-js/actions/runs/7985041805/job/21802827410?pr=1625 [2] npm/cli#4828
VeskeR
force-pushed
the
1622/fix-ably-react-import
branch
from
86ee859 to
0bffeb7
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1625/features
github-actions
bot
temporarily deployed
to
staging/pull/1625/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1625/typedoc
Base automatically changed from
1619/fix-ably-import-in-react-hooks
to
integration/v2
February 21, 2024 20:14
Sure! I totally missed it had a README |
|
Updated README and npm scripts |
lawrence-forooghian
approved these changes
Feb 26, 2024
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1624 so review that one first.
Fixes missing
ably/reactexport from ably-js NPM package on v2 branch.Adds a test case to
test:packagescript to confirm that we are able to import fromably/reactfrom ably-js NPM package, mostly based on the guide from playwright Components.See commit messages for more details.
Resolves #1622