Refactor the Fallbacks feature #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 'Service'. I feel this way of grouping is more logical and easier to understand. I'm going to cover `RTN17e` in a separate PR.
lmars
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @lmars' observations around the potential oversight of Fallbacks.
see: #3 (comment)
I feel this way of grouping is more logical and easier to understand. We're also now referencing more sub-points from
RSC15andRTN17.It's worth noting that
RTN17chas quite a journey of spec point mutation in its lifespan at Ably, which is not ideal, but explains why it's referenced from multiple feature nodes.I'm going to cover
RTN17ein a separate pull request, as that will require therequiresfeature node property to add support for having multiple feature nodes upon which it requires.