Add feature node for RTN17e - REST following Realtime fallback host selection
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmars
reviewed
Oct 3, 2022
Co-authored-by: Lewis Marshall <lewis@lmars.net>
|
Thanks for your observation, @lmars - I've committed your suggestion as is. I had taken that wording from the features spec, and if I recall correctly it's circa 2016 vintage. |
lmars
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the work I believe is required to address @lmars' observations around the potential oversight of Fallbacks, building on the work done in #66.
see: #3 (comment)
I had to enhance the
requiresfeature node property to allow a feature node to require multiple feature nodes.