[ECO-4868] Upgrade to ably-js v2 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeskeR
force-pushed
the
321/upgrade-to-ably-js-v2
branch
from
d865c18
to
7a1c4f6
Compare
VeskeR
force-pushed
the
321/upgrade-to-ably-js-v2
branch
from
7a1c4f6
to
2b7aea7
Compare
VeskeR
force-pushed
the
321/upgrade-to-ably-js-v2
branch
from
2b7aea7
to
20f050b
Compare
Do not try to fix possible errors yet, just simply update every place to use ably-js v2 API.
`clientId` prop was made optional in ably-js v2 [1] to be consistent with the feature spec. However, spaces SDK requires `clientId` to be always set, so we can expect it to be present. [1] ably/ably-js@4e3733f
PaginatedResult.next() type was updated in ably-js v2 [1] to return null in case of no page. [1] ably/ably-js@8bd1706
`Message.data` was made optional in ably-js v2 [1] [1] ably/ably-js@4e3733f
…whenState() Callback API for RealtimeChannel.whenState() was removed in ably-js v2 [1] [1] ably/ably-js@2a2ed49
VeskeR
force-pushed
the
321/upgrade-to-ably-js-v2
branch
from
20f050b
to
3c5fac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #321
See commit messages for more details