-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4868] Upgrade to ably-js v2 #325
Merged
Merged
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48d5b48 - Browse repository at this point
Copy the full SHA 48d5b48View commit details -
Do not try to fix possible errors yet, just simply update every place to use ably-js v2 API.
Configuration menu - View commit details
-
Copy full SHA for 2d133e3 - Browse repository at this point
Copy the full SHA 2d133e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93db3f0 - Browse repository at this point
Copy the full SHA 93db3f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b9c60b - Browse repository at this point
Copy the full SHA 0b9c60bView commit details -
Fix 'clientId' is undefined for RealtimeMessage
`clientId` prop was made optional in ably-js v2 [1] to be consistent with the feature spec. However, spaces SDK requires `clientId` to be always set, so we can expect it to be present. [1] ably/ably-js@4e3733f
Configuration menu - View commit details
-
Copy full SHA for 2ed5641 - Browse repository at this point
Copy the full SHA 2ed5641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e78112 - Browse repository at this point
Copy the full SHA 9e78112View commit details -
Fix PaginatedResult.next() usage
PaginatedResult.next() type was updated in ably-js v2 [1] to return null in case of no page. [1] ably/ably-js@8bd1706
Configuration menu - View commit details
-
Copy full SHA for d59c4a3 - Browse repository at this point
Copy the full SHA d59c4a3View commit details -
`Message.data` was made optional in ably-js v2 [1] [1] ably/ably-js@4e3733f
Configuration menu - View commit details
-
Copy full SHA for 463a572 - Browse repository at this point
Copy the full SHA 463a572View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7e1177 - Browse repository at this point
Copy the full SHA e7e1177View commit details -
Fix integration.test.ts used deprecated callback for RealtimeChannel.…
…whenState() Callback API for RealtimeChannel.whenState() was removed in ably-js v2 [1] [1] ably/ably-js@2a2ed49
Configuration menu - View commit details
-
Copy full SHA for 3c5fac5 - Browse repository at this point
Copy the full SHA 3c5fac5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.