Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4868] Upgrade to ably-js v2 #325

Merged
merged 10 commits into from
Jul 17, 2024
Merged

[ECO-4868] Upgrade to ably-js v2 #325

merged 10 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. Configuration menu
    Copy the full SHA
    48d5b48 View commit details
    Browse the repository at this point in the history
  2. Update to use ably-js v2 API

    Do not try to fix possible errors yet, just simply update every place
    to use ably-js v2 API.
    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2d133e3 View commit details
    Browse the repository at this point in the history
  3. Update docs re ably-js v2 API

    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    93db3f0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0b9c60b View commit details
    Browse the repository at this point in the history
  5. Fix 'clientId' is undefined for RealtimeMessage

    `clientId` prop was made optional in ably-js v2 [1] to be consistent
    with the feature spec. However, spaces SDK requires `clientId` to be
    always set, so we can expect it to be present.
    
    [1] ably/ably-js@4e3733f
    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    2ed5641 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9e78112 View commit details
    Browse the repository at this point in the history
  7. Fix PaginatedResult.next() usage

    PaginatedResult.next() type was updated in ably-js v2 [1] to return null
    in case of no page.
    
    [1] ably/ably-js@8bd1706
    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d59c4a3 View commit details
    Browse the repository at this point in the history
  8. Fix Message.data is undefined

    `Message.data` was made optional in ably-js v2 [1]
    
    [1] ably/ably-js@4e3733f
    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    463a572 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e7e1177 View commit details
    Browse the repository at this point in the history
  10. Fix integration.test.ts used deprecated callback for RealtimeChannel.…

    …whenState()
    
    Callback API for RealtimeChannel.whenState() was removed in ably-js v2 [1]
    
    [1] ably/ably-js@2a2ed49
    VeskeR committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    3c5fac5 View commit details
    Browse the repository at this point in the history