Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMB-152] Update README #83

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[MMB-152] Update README #83

merged 1 commit into from
Jul 17, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Jul 4, 2023 •
edited
Loading

https://ably.atlassian.net/browse/MMB-155

Update README:

  • prioritize quick start examples
  • condense the amount of copy
  • create examples that can be copied into applications (as much as possible)

artismarti
artismarti approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@artismarti artismarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback :)

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dpiatek dpiatek changed the title Update README [MMB-152] Update README Jul 7, 2023
dpiatek
dpiatek commented Jul 7, 2023
View reviewed changes
README.md Show resolved Hide resolved
dpiatek
dpiatek commented Jul 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
dpiatek
dpiatek commented Jul 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Srushtika
Srushtika requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested. Otherwise, looks great!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@m-hulbert m-hulbert requested a review from Srushtika July 10, 2023 12:06
Srushtika
Srushtika approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@m-hulbert m-hulbert merged commit e159ff0 into main Jul 17, 2023
5 checks passed
@m-hulbert m-hulbert deleted the readme-updates branch July 17, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artismarti artismarti artismarti approved these changes

@Srushtika Srushtika Srushtika approved these changes

@m-hulbert m-hulbert Awaiting requested review from m-hulbert

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpiatek @artismarti @Srushtika @m-hulbert